Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machine-api resources #118

Open
wants to merge 1 commit into
base: master
from

Conversation

@michaelgugino
Copy link

commented Aug 5, 2019

Current must-gather script returns no items for
things inside openshift-machine-api namespace.

This commit adds support for those items by specifying
namespace in gather script.

https://jira.coreos.com/browse/CLOUD-558

Fix machine-api resources
Current must-gather script returns no items for
things inside openshift-machine-api namespace.

This commit adds support for those items by specifying
namespace in gather script.
@openshift-ci-robot

This comment has been minimized.

Copy link

commented Aug 5, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: michaelgugino
To complete the pull request process, please assign rickjwagner
You can assign the PR to them by writing /assign @rickjwagner in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


# Run the Collection of Resources using must-gather
for resource in ${resources[@]}; do
/usr/bin/openshift-must-gather inspect ${resource}
done

# Run the Collection of MachineAPIResources using must-gather

This comment has been minimized.

Copy link
@sferich888

sferich888 Aug 12, 2019

Contributor

Why collect this separate? Why not just included this in resources?

# Machine/Node Resources
resources+=(nodes machines machineconfigs machineconfigpools)
# MCO/Node Resources
resources+=(nodes machineconfigs machineconfigpools)

This comment has been minimized.

Copy link
@sferich888

sferich888 Aug 12, 2019

Contributor

Do we have a relation ship between these?
IE: If we get a node; do we need to know its machineconfigs or machineconfigpools?

If so - it might be better to put this relationship into to the must-gather binary so every time a node is collected *(or one of the other objects); the proper related objects are collected.

This comment has been minimized.

Copy link
@ingvagabund

ingvagabund Aug 12, 2019

Member

I can't speak for everyone though I believe machineconfigs and machineconfigpools are namespace-less. That's why we need to query for machines separately since they live only under openshift-machine-api namespace.

This comment has been minimized.

Copy link
@ingvagabund

This comment has been minimized.

Copy link
@ingvagabund

ingvagabund Aug 19, 2019

Member

@sferich888 I have a feeling it's impossible to know which machine config was used for a given node just by quering node. Based on posted [1], I don't think node object has any field/label/annotation that can say which endpoint was used. Also, worker nodes have different image than master nodes. Each image knows an endpoint (most likely it's hard-coded in it when it's baked). Due to security reason so you can't pretend to be master when you are worker. Or, am I wrong @runcom @ashcrow ?

[1] https://github.com/openshift/machine-config-operator/blob/master/docs/MachineConfigServer.md#detailed-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.