Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/monitoring: gather replica specific data #248

Merged

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jul 15, 2021

Collect Monitoring data for each Prometheus replica in the following endpoints:

  • status/tsdb

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

Hi @mtulio. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 15, 2021
@dgrisonnet
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@mtulio
Copy link
Contributor Author

mtulio commented Jul 22, 2021

/assign @sferich888

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@mtulio
Copy link
Contributor Author

mtulio commented Aug 6, 2021

@dgrisonnet @davemulford PTAL ?

Result of tests:

$ oc adm must-gather --dest-dir=pr258 --image=quay.io/mtulio/must-gather:pr248 -- gather_monitoring

$ ls -s pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.stderr
0 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-0/status/tsdb.stderr
0 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-1/status/tsdb.stderr

$ ls -s pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.json
4 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-0/status/tsdb.json
4 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-1/status/tsdb.json

$ for STF in $( ls pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.json) ; do jq .data.headStats.numSeries $STF ; done
215426
214579

@davemulford
Copy link

Look great! As soon as @dgrisonnet also comments, I can LGTM this.

@sferich888
Copy link
Contributor

@dgrisonnet any updates or a reason not to LGTM this?

Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but it looks good to me overall.

cc @simonpasquier for awareness.

collection-scripts/gather_monitoring Outdated Show resolved Hide resolved
collection-scripts/gather_monitoring Outdated Show resolved Hide resolved
@sferich888
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mtulio, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit d027707 into openshift:master Nov 1, 2021
@mtulio mtulio deleted the gather-prom-replicas-tsdb branch November 9, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants