New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/monitoring: gather replica specific data #248
feat/monitoring: gather replica specific data #248
Conversation
Hi @mtulio. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/assign @sferich888 |
@dgrisonnet @davemulford PTAL ? Result of tests: $ oc adm must-gather --dest-dir=pr258 --image=quay.io/mtulio/must-gather:pr248 -- gather_monitoring
$ ls -s pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.stderr
0 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-0/status/tsdb.stderr
0 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-1/status/tsdb.stderr
$ ls -s pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.json
4 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-0/status/tsdb.json
4 pr258/quay-io-mtulio-must-gather-sha256-e1301a00005c8c67510f66fe9139bea26b8280d97fd6d4f20e89a5f5ab6a42fe/monitoring/prometheus/prometheus-k8s-1/status/tsdb.json
$ for STF in $( ls pr258/*/monitoring/prometheus/prometheus-k8s-*/status/tsdb.json) ; do jq .data.headStats.numSeries $STF ; done
215426
214579
|
Look great! As soon as @dgrisonnet also comments, I can LGTM this. |
@dgrisonnet any updates or a reason not to LGTM this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but it looks good to me overall.
cc @simonpasquier for awareness.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mtulio, sferich888 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collect Monitoring data for each Prometheus replica in the following endpoints:
status/tsdb