Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2091658: Improve the sriov gather script #305

Merged
merged 1 commit into from May 31, 2022
Merged

Bug 2091658: Improve the sriov gather script #305

merged 1 commit into from May 31, 2022

Conversation

liornoy
Copy link
Contributor

@liornoy liornoy commented May 25, 2022

Added improvments to the sriov gather script:

  1. Use the SRIOV_NS var instead of static: "openshift-sriov-network-operator".
  2. In the gather_ethtool function, do not log interfaces with @ in the name.

@liornoy
Fix sriov gather
2c07761 
Added improvments to the sriov gather script:
1. Use the SRIOV_NS var instead of static: "openshift-sriov-network-operator".
2. In the gather_ethtool function, do not log interfaces with @ in the name.
@liornoy
Copy link
Contributor Author

liornoy commented May 25, 2022

@SchSeba please review =)

SchSeba
SchSeba reviewed May 25, 2022
View reviewed changes
Copy link

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks!

bn222
bn222 reviewed May 25, 2022
View reviewed changes
collection-scripts/gather_sriov

# Run ethtool for each interface except for lo.
while IFS= read -r interface; do
if [ -z "$interface" ] || [ "$interface" = "lo" ]; then
if [ -z "$interface" ] || [ "$interface" = "lo" ] || [[ "$interface" == *"@"* ]]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to remove all the veth (ovn-k) related interfaces.

there is no need for sriov must-gather to get that information.

RickJWagner
RickJWagner approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@zeeke
Copy link

zeeke commented May 30, 2022

@RickJWagner can you please (if you have the permissions) change the title of this PR in

Bug 2091658: Improve the sriov gather script

as a BZ is needed for it to get merged

@RickJWagner
Copy link
Contributor

Hi @zeeke
I've made a change to the title of https://bugzilla.redhat.com/show_bug.cgi?id=2091658 to match this issue tracker.
Please have a look, let me know if it needs adjusted, etc.

@RickJWagner
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liornoy, RickJWagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zeeke
Copy link

zeeke commented May 31, 2022

/retitle Bug 2091658: Improve the sriov gather script

@openshift-ci openshift-ci bot changed the title Improve the sriov gather script Bug 2091658: Improve the sriov gather script May 31, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@liornoy: This pull request references Bugzilla bug 2091658, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2091658: Improve the sriov gather script

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zeeke
Copy link

zeeke commented May 31, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@zeeke: This pull request references Bugzilla bug 2091658, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi May 31, 2022 16:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

@liornoy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 87c1fd3 into openshift:master May 31, 2022
@liornoy liornoy deleted the fixsriovgather branch June 2, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchSeba SchSeba SchSeba left review comments

@bn222 bn222 bn222 left review comments

@RickJWagner RickJWagner RickJWagner approved these changes

@davemulford davemulford Awaiting requested review from davemulford

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@RickJWagner RickJWagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liornoy @zeeke @RickJWagner @SchSeba @bn222 @openshift-merge-robot