Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2097346: Updates how gather_monitoring obtains SA token #313

Merged
merged 1 commit into from Jun 15, 2022
Merged

Bug 2097346: Updates how gather_monitoring obtains SA token #313

merged 1 commit into from Jun 15, 2022

Conversation

JoaoBraveCoding
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding commented Jun 15, 2022 •
edited

Issue: https://bugzilla.redhat.com/show_bug.cgi?id=2097346

problem: since k8s 1.24 tokens for SA are not automatically generated [1]
hence, it's not possible to get a SA token with the command
"oc sa get-token default", this breaks the gather_monitoring script as
we need the token to make http requests to prometheus

solution: use instead the new command "oc create token default"

[1] kubernetes/kubernetes#108309

@JoaoBraveCoding
Updates how gether_monitoring obtains SA token
b3de331 
problem: Since k8s 1.24 tokens for SA are not automatically generated [1]
hence, it's not possible to get a SA token with the command
"oc sa get-token default", this breaks the gather_monitoring script as
we need the token to make http requests to prometheus

solution: use instead the new command "oc create token default"

[1] kubernetes/kubernetes#108309
@JoaoBraveCoding JoaoBraveCoding changed the title Updates how gether_monitoring obtains SA token Bug 2097346: Updates how gether_monitoring obtains SA token Jun 15, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JoaoBraveCoding: This pull request references Bugzilla bug 2097346, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 2097346: Updates how gether_monitoring obtains SA token

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 15, 2022
@openshift-ci openshift-ci bot requested a review from juzhao June 15, 2022 13:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JoaoBraveCoding: This pull request references Bugzilla bug 2097346, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

Bug 2097346: Updates how gether_monitoring obtains SA token

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link

/retest

@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JoaoBraveCoding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member

wking commented Jun 15, 2022

e2e looks good :) :

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_must-gather/313/pull-ci-openshift-must-gather-master-e2e-aws/1537071260243070976/artifacts/e2e-aws/gather-must-gather/artifacts/must-gather.tar | tar tvz | grep /monitoring/
drwxr-xr-x 1009340000/root       0 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/alertmanager
-rw------- 1009340000/root    1814 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/alertmanager/status.json
-rw------- 1009340000/root       0 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/alertmanager/status.stderr
drwxr-xr-x 1009340000/root       0 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/prometheus
-rw------- 1009340000/root    3866 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/prometheus/alertmanagers.json
-rw------- 1009340000/root       0 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/prometheus/alertmanagers.stderr
drwxr-xr-x 1009340000/root       0 2022-06-15 08:32 registry-build03-ci-openshift-org-ci-op-qrsrg6hw-stable-sha256-234d5e5abc2088e0e254aec0a5623064003ce9de5efe3d30fa95a9acd017f34b/monitoring/prometheus/prometheus-k8s-0
...

RickJWagner
RickJWagner approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR. Please make one alteration, though. Change typo in title so it's 'gather_monitoring' instead of 'gether_monitoring', for clarity.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, RickJWagner, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@openshift-ci openshift-ci bot merged commit 6a8ee9f into openshift:master Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@JoaoBraveCoding: All pull requests linked via external trackers have merged:

Bugzilla bug 2097346 has been moved to the MODIFIED state.

In response to this:

Bug 2097346: Updates how gether_monitoring obtains SA token

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link

/retitle Bug 2097346: Updates how gather_monitoring obtains SA token

@openshift-ci openshift-ci bot changed the title Bug 2097346: Updates how gether_monitoring obtains SA token Bug 2097346: Updates how gather_monitoring obtains SA token Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickJWagner RickJWagner RickJWagner approved these changes

@sferich888 sferich888 Awaiting requested review from sferich888

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoaoBraveCoding @simonpasquier @wking @RickJWagner