New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align to upstream v1.4.0 #109
Align to upstream v1.4.0 #109
Conversation
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Use the non-cgo version for all openbsd architectures. The old code only pulled some defines from header files. Just add them as enumerations in native go. Also be careful at what the SysctlRaw returns. Implement a way that supports both recent and old pre-6.4 OpenBSD systems. With go-1.16 OpenBSD binaries will link to libc and because of this binaries built on OpenBSD 6.9-current do not run on OpenBSD 6.3. OpenBSD 6.3 is also not supported for more then 2 years. So maybe the compat code is not needed. Still validation object length before doing an unsafe pointer conversion is probably reasonable but I'm no golang expert. Signed-off-by: Claudio Jeker <claudio@openbsd.org>
Signed-off-by: Matt Oshry <matto@spatialinc.com>
This adds a new Linux metric, node_softirqs_total, which corresponds to the 'softirq' line in /proc/stat. This metric is disabled by default and it can be enabled with '--collector.stat.softirq'. Signed-off-by: Jacob Vosmaer <jacob@gitlab.com>
Replace invalid UTF-8 chars with "�" string. Fixes: prometheus#2228 Signed-off-by: Ben Kochie <superq@gmail.com>
* Ignore filesystems flagges as MNT_IGNORE. Closes prometheus#2152. Signed-off-by: Lapo Luchini <lapo@lapo.it>
* [BUGFIX] Handle nil CPU thermal power status on M1 prometheus#2218 * [BUGFIX] bsd: Ignore filesystems flagged as MNT_IGNORE. prometheus#2227 * [BUGFIX] Sanitize UTF-8 in dmi collector prometheus#2229 Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: heyitao <linuxgcc@163.com>
See prometheus#2243 Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Synchronize common files from prometheus/prometheus
Allow filtering APR entries based on device. Useful for ignoring entries for network namespaces (containers). Signed-off-by: Ben Kochie <superq@gmail.com>
Add device filter flags to arp collector
analogous to the /var/lib/docker exclude added in prometheus#814 podman rootful containers mount eg. shm filesystems at /var/lib/containers/storage/*-containers/*/userdata/shm. these should be treated like things under /var/lib/docker by default. Signed-off-by: Lauri Tirkkonen <lauri@hacktheplanet.fi>
Signed-off-by: Robbie Lankford <robert.lankford@grafana.com>
Point users at the community website. Signed-off-by: Ben Kochie <superq@gmail.com>
Update issue template.
Signed-off-by: Severyn Lisovskyi <993215+sev3ryn@users.noreply.github.com>
systemd patch versions are as important as the major version number; they indicate security or bug fixes or other behavioural changes between versions. Use float64 over float32 as the rounding error with float32 rendered 250.3 as 250.3000030517578 in my testing. Signed-off-by: Joe Groocock <jgroocock@cloudflare.com> Signed-off-by: Joe Groocock <me@frebib.net>
systemd: Expose systemd minor version
Move the systemd version function to an exporter method. This way we can update the Verison information at every scrape, in case the underlying version changes. Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: t-falconnet <tfalconnet.externe@bedrockstreaming.com>
Signed-off-by: t-falconnet <tfalconnet.externe@bedrockstreaming.com>
Signed-off-by: t-falconnet <tfalconnet.externe@bedrockstreaming.com>
Signed-off-by: t-falconnet <tfalconnet.externe@bedrockstreaming.com>
Signed-off-by: t-falconnet <tfalconnet.externe@bedrockstreaming.com>
Signed-off-by: Public <latchkey@gmail.com> Signed-off-by: Public Profile <latchkey@gmail.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
iostat: update due to visible deprecated warning on osx
[node-mixin] change current datasource to grafana's default
Return the copyright date in `collector/cpu_openbsd.go` to the original value. Minor change revert on prometheus#1971 Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: binjip978 <pdp.eleven11@gmail.com> Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
…sd_date Fix up copyright date change
* Allow user to select port on NTP server to query Some people (me!) run NTP servers on non-privileged ports. The `github.com/beevik/ntp` package allows overriding the port, so this change just adds a flag `collector.ntp.server-port` (defaults to 123) and then passes that value through to the query via the `QueryOptions`. Signed-off-by: Andrew Rowson <github@growse.com>
Signed-off-by: Johannes Ziemke <github@5pi.de>
Signed-off-by: inosato <si17_21@yahoo.co.jp>
…metheus#2191) * Add stalled frontend/backend cycles counters for perf collector Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com> * Update collector/perf_linux.go Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com> * Update collector/perf_linux.go Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Cosrider <cosrider7@gmail.com>
* Fix some mistakes * Switch to an ignore file. Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>
…prometheus#2459) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](jsimonetti/rtnetlink@v1.2.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.2 to 1.13.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.12.2...v1.13.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mutex to prevent race condition. Signed-off-by: Robin Nabel <rnabel@ucdavis.edu>
Signed-off-by: Serhii Freidin <sfreydin@macpaw.com> Signed-off-by: Serhii Freidin <sfreydin@macpaw.com>
The textfile collector will now provide a unified metric description (that will look like "Metric read from file/a.prom, file/b.prom") for metrics collected accross several text-files that don't already have a description. Also change the error handling in the textfile collector tests to ContinueOnError to better mirror the real-life use-case. Signed-off-by: Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com> Signed-off-by: Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com>
skip over the zfs IO metrics if their paths are missing Signed-off-by: tnextday <fw2k4@163.com> Signed-off-by: tnextday <fw2k4@163.com>
* Improve metrics filesystem scanning logic * Makes ioctl syscalls to load the device error stats. * Adds filesystem mountpoint labels to existing metrics for ease of use. Signed-off-by: Marcus Cobden <leth@users.noreply.github.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: prombot <prometheus-team@googlegroups.com>
* [CHANGE] Merge metrics descriptions in textfile collector prometheus#2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin prometheus#2351 * [FEATURE] Add "isolated" metric on cpu collector on linux prometheus#2251 * [FEATURE] Add cgroup summary collector prometheus#2408 * [FEATURE] Add selinux collector prometheus#2205 * [FEATURE] Add slab info collector prometheus#2376 * [FEATURE] Add sysctl collector prometheus#2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems prometheus#1971 * [FEATURE] Add support for MacOS version prometheus#2471 * [ENHANCEMENT] [node-mixin] Add missing selectors prometheus#2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default prometheus#2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table prometheus#2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util prometheus#2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd prometheus#2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin prometheus#2240 * [ENHANCEMENT] Add device filter flags to arp collector prometheus#2254 * [ENHANCEMENT] Add diskstats include and exclude device flags prometheus#2417 * [ENHANCEMENT] Add node_softirqs_total metric prometheus#2221 * [ENHANCEMENT] Add rapl zone name label option prometheus#2401 * [ENHANCEMENT] Add slabinfo collector prometheus#1799 * [ENHANCEMENT] Allow user to select port on NTP server to query prometheus#2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev prometheus#2404 * [ENHANCEMENT] Enable builds against older macOS SDK prometheus#2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name prometheus#2432 * [ENHANCEMENT] systemd: Expose systemd minor version prometheus#2282 * [ENHANCEMENT] Use netlink for tcpstat collector prometheus#2322 * [ENHANCEMENT] Use netlink to get netdev stats prometheus#2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles prometheus#2191 * [ENHANCEMENT] Add btrfs device error stats prometheus#2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning prometheus#2352 * [BUGFIX] Fix concurrency issue in ethtool collector prometheus#2289 * [BUGFIX] Fix concurrency issue in netdev collector prometheus#2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes prometheus#2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning prometheus#2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts prometheus#2340 * [BUGFIX] Sanitize rapl zone names prometheus#2299 * [BUGFIX] Add file descriptor close safely in test prometheus#2447 * [BUGFIX] Fix race condition in os_release.go prometheus#2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing prometheus#2451 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>
/test e2e-agnostic-cmo |
This new release comes with the new selinux collector which is enabled by default. The collector adds 3 metrics per node:
Other changes:
Overall I don't see anything that would block us from merging this PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@raptorsun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.