Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused files from e2e folder #1283

Conversation

mateusoliveira43
Copy link
Contributor

Description

Remove files not used by end-to-end tests code.

TODO

Check documentation, some of the files may be still referenced there.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2024
Copy link

openshift-ci bot commented Jan 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mateusoliveira43
Once this PR has been reviewed and has the lgtm label, please assign shawn-hurley for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weshayutin
Copy link
Contributor

So I am probably to blame for a lot of these files. Happy to figure out a reorg / rewrite with in the context of symlinks to developer doc, and downstream bvt automation. Said a different way many of these files are not directly used in the e2e, however they are used elsewhere.

@weshayutin
Copy link
Contributor

OK.. the following directories are OK to delete.

  • block-pv
  • deprecated

Everything else needs to stay as it's a reference in doc or used by other tools.
Thanks for going through it.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2024
Copy link

openshift-ci bot commented Jun 19, 2024

@mateusoliveira43: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.16-e2e-test-kubevirt-aws 7fe197e link true /test 4.16-e2e-test-kubevirt-aws
ci/prow/4.15-e2e-test-kubevirt-aws 7fe197e link true /test 4.15-e2e-test-kubevirt-aws
ci/prow/4.16-e2e-test-aws 7fe197e link true /test 4.16-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mateusoliveira43
Copy link
Contributor Author

closing as I deleted what I could in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants