Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.1] Bug 1762750: Fix high memory usage #138

Merged
merged 2 commits into from Dec 12, 2019
Merged

[release-4.1] Bug 1762750: Fix high memory usage #138

merged 2 commits into from Dec 12, 2019

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #137

/assign stlaz

@stlaz
re-use openshift http client to prevent high memory usage
c0cc6d7 
Creating a new http.client object with every request, re-reading the
CA files, can cause the oauth-proxy container to eventually get
killed with OOM errors as the clients are not actually getting
released anywhere.

Re-use the clients based on checking whether their CA files actually
changed or not - the check for change is based on last-modified
timestamp and size metadata of each CA cert file.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 9, 2019
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1759169, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.3.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1759169: Fix high memory usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2019
@enj
Copy link

enj commented Oct 16, 2019

/uncc

@stlaz @sttts @mfojtik

@openshift-ci-robot openshift-ci-robot removed the request for review from enj October 16, 2019 15:07
@openshift-bot
Copy link

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1759169, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "4.3.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed, recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz stlaz changed the title [release-4.1] Bug 1759169: Fix high memory usage [release-4.1] Bug 1762750: Fix high memory usage Oct 17, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1762750, which is invalid:

  • expected dependent Bugzilla bug 1762748 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.1] Bug 1762750: Fix high memory usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member

stlaz commented Dec 3, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1762750, which is invalid:

  • expected the bug to target the "4.1.z" release, but it targets "3.11.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stlaz
Copy link
Member

stlaz commented Dec 3, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 3, 2019
@openshift-ci-robot
Copy link

@stlaz: This pull request references Bugzilla bug 1762750, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 3, 2019
sttts
sttts reviewed Dec 3, 2019
View reviewed changes
util/util.go Outdated Show resolved Hide resolved
@stlaz stlaz force-pushed the cherry-pick-137-to-release-4.1 branch from dcaf72d to 1d81340 Compare December 3, 2019 13:13
@stlaz stlaz force-pushed the cherry-pick-137-to-release-4.1 branch from 1d81340 to a63d88f Compare December 3, 2019 13:17
@sttts
Copy link

sttts commented Dec 4, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2019
@sttts
Copy link

sttts commented Dec 12, 2019

/approve

1 similar comment
@mfojtik
Copy link
Member

mfojtik commented Dec 12, 2019

/approve

@mfojtik mfojtik added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mfojtik, openshift-cherrypick-robot, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 0fb6013 into openshift:release-4.1 Dec 12, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1762750 has been moved to the MODIFIED state.

In response to this:

[release-4.1] Bug 1762750: Fix high memory usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@sttts sttts sttts left review comments

@ericavonb ericavonb Awaiting requested review from ericavonb

Assignees

@stlaz stlaz

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @openshift-ci-robot @enj @openshift-bot @stlaz @sttts @mfojtik @bparees @openshift-merge-robot