Bug 1788419: bump kube to 1.17, use gomod #147
Conversation
openshift-ci-robot
added
size/XXL
|
/test e2e-aws |
stlaz
changed the title
|
@stlaz: This pull request references Bugzilla bug 1788419, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
I'm fine with the change, it's good in and of itself. It's not obvious to me why you think this fixes your problem though. /lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stlaz you may want to update the Go version used by Travis to 1.13 as well (https://github.com/openshift/oauth-proxy/blob/master/.travis.yml#L4) |
|
@LorbusChris thanks for the suggestion. I am not sure openshift 3.9, which is being built there, could take it. My plan is to move away from Travis anyway, and use our common testing machinery which sets its own real cluster up soon, so I'd stick with the go version we've got there for now. |
|
Oh I missed that it's still on 3.9, nevermind then :) |
|
/retest |
|
/lgtm |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
fixed config evaluation when no client CA is specified for delegated auth and replaced |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stlaz, vareti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1788419 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Latest kube-deps bump was in November 2017 and it most probably was taken from master...