Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2090692: Beautify help and align with kubectl output #1121

Merged
merged 4 commits into from Jun 3, 2022
Merged

Bug 2090692: Beautify help and align with kubectl output #1121

merged 4 commits into from Jun 3, 2022

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Apr 28, 2022

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik April 28, 2022 17:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2022
@ardaguclu
Copy link
Member

This PR looks good to me. But tests are failing;
error calling flagsUsages: file descriptor is not a terminal

Maybe we should change tests prior to this PR?

@soltysh soltysh mentioned this pull request Apr 29, 2022
Merged
@soltysh
Copy link
Member Author

soltysh commented Apr 29, 2022

/hold
for kubernetes/kubernetes#109722 and it's 1.24 pick to land first

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2022
@soltysh soltysh changed the title Beautify help and align with kubectl output Bug 2090692: Beautify help and align with kubectl output May 26, 2022
@soltysh
Copy link
Member Author

soltysh commented May 26, 2022

/hold cancel

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2022

@soltysh: This pull request references Bugzilla bug 2090692, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Bug 2090692: Beautify help and align with kubectl output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 May 26, 2022 11:13
@ardaguclu
Copy link
Member

This looks great. I'll label it after jobs passed.

@soltysh
Copy link
Member Author

soltysh commented May 26, 2022

This looks great. I'll label it after jobs passed.

Wait until you see the output from oc get -h - so much more pleasant to the eye 😄

@soltysh
Copy link
Member Author

soltysh commented May 26, 2022

/test e2e-aws-serial

@soltysh
Copy link
Member Author

soltysh commented May 26, 2022

/hold
test-cmd failures look real

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2022
@soltysh soltysh mentioned this pull request May 27, 2022
Merged
@soltysh
Copy link
Member Author

soltysh commented May 27, 2022

/retest-required

@soltysh
Copy link
Member Author

soltysh commented May 29, 2022

/test e2e-aws-upgrade
/test e2e-agnostic-cmd

1 similar comment
@soltysh
Copy link
Member Author

soltysh commented May 30, 2022

/test e2e-aws-upgrade
/test e2e-agnostic-cmd

@soltysh soltysh mentioned this pull request May 30, 2022
Merged
@ardaguclu
Copy link
Member

/test e2e-aws
/test e2e-metal-ipi-ovn-ipv6
/test e2e-agnostic-cmd

@soltysh
Copy link
Member Author

soltysh commented May 31, 2022

/hold cancel
/test e2e-agnostic-cmd

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@ardaguclu
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 9fc2d0e and 8 for PR HEAD 12ea962 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 9fc2d0e and 7 for PR HEAD 12ea962 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9fc2d0e and 6 for PR HEAD 12ea962 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 1bd2ef0 and 5 for PR HEAD 12ea962 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 1bd2ef0 and 4 for PR HEAD 12ea962 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 1bd2ef0 and 4 for PR HEAD 12ea962 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1bd2ef0 and 3 for PR HEAD 12ea962 in total

@soltysh
Copy link
Member Author

soltysh commented Jun 2, 2022

/test e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022 •
edited

@soltysh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 12ea962 link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Member Author

soltysh commented Jun 3, 2022

/test e2e-aws-upgrade

@openshift-merge-robot openshift-merge-robot merged commit 03b210b into openshift:master Jun 3, 2022
10 of 12 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@soltysh: All pull requests linked via external trackers have merged:

Bugzilla bug 2090692 has been moved to the MODIFIED state.

In response to this:

Bug 2090692: Beautify help and align with kubectl output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the beautify_help branch June 3, 2022 15:30
@openshift-ci openshift-ci bot mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

Assignees

@deejross deejross

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@soltysh @ardaguclu @openshift-ci-robot @deejross @openshift-merge-robot