Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2080416: Fix project command auto completion #1125

Merged

Conversation

ardaguclu
Copy link
Member

Currently if user enters after oc project, it auto completes
as oc project project. This PR fixes that and after entering ,
it lists all projects.

Currently if user enters <tab> after `oc project`, it completes
as `oc project project`. This PR fixes that and after entering <tab>,
it lists all projects.
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@ardaguclu: This pull request references Bugzilla bug 2080416, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

Bug 2080416: Fix project command auto completion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/uncc @deads2k @mfojtik
/cc @soltysh @deejross

@openshift-ci openshift-ci bot requested review from deejross and soltysh and removed request for mfojtik and deads2k May 5, 2022 13:33
@ardaguclu
Copy link
Member Author

/retest-required

@ardaguclu
Copy link
Member Author

/retest

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 42714a5 into openshift:master May 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2022

@ardaguclu: All pull requests linked via external trackers have merged:

Bugzilla bug 2080416 has been moved to the MODIFIED state.

In response to this:

Bug 2080416: Fix project command auto completion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu ardaguclu deleted the project-completion branch May 6, 2022 19:21
@ardaguclu
Copy link
Member Author

/cherry-pick release-4.10

@openshift-cherrypick-robot

@ardaguclu: #1125 failed to apply on top of branch "release-4.10":

Applying: Fix project command auto completion
Using index info to reconstruct a base tree...
M	pkg/cli/project/project.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cli/project/project.go
CONFLICT (content): Merge conflict in pkg/cli/project/project.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix project command auto completion
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants