Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-10622: bump repo sclorg/s2i-ruby-container location for newapp test #1377

Merged
merged 1 commit into from Mar 22, 2023
Merged

OCPBUGS-10622: bump repo sclorg/s2i-ruby-container location for newapp test #1377

merged 1 commit into from Mar 22, 2023

Conversation

atiratree
Copy link
Member

needed because of the files removal in sclorg/s2i-ruby-container#462

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 21, 2023
@openshift-ci-robot
Copy link

@atiratree: This pull request references Jira Issue OCPBUGS-10622, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

needed because of the files removal in sclorg/s2i-ruby-container#462

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 21, 2023
Merged
Merged
soltysh
soltysh approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07ee29c and 2 for PR HEAD 906a3bb in total

@ardaguclu
Copy link
Member

/retest-required

1 similar comment
@atiratree
Copy link
Member Author

/retest-required

@ardaguclu ardaguclu mentioned this pull request Mar 22, 2023
Merged
@Jamstah Jamstah mentioned this pull request Mar 22, 2023
Merged
@soltysh
Copy link
Member

soltysh commented Mar 22, 2023

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade
the failures are not related, and this PR fixes a unit test which is blocking other PRs.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-upgrade
the failures are not related, and this PR fixes a unit test which is blocking other PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b860ec0 into openshift:master Mar 22, 2023
13 checks passed
@openshift-ci-robot
Copy link

@atiratree: Jira Issue OCPBUGS-10622: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-10622 has been moved to the MODIFIED state.

In response to this:

needed because of the files removal in sclorg/s2i-ruby-container#462

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prb112
Copy link
Contributor

prb112 commented Mar 22, 2023

awesome

@ingvagabund ingvagabund mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1380

In response to this:

/cherrypick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atiratree
Copy link
Member Author

/cherrypick release-4.13

@atiratree
Copy link
Member Author

/cherrypick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1381

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1382

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atiratree
Copy link
Member Author

/cherrypick release-4.10

@atiratree
Copy link
Member Author

/cherrypick release-4.9

@atiratree
Copy link
Member Author

/cherrypick release-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Merged
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1383

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Closed
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1384

In response to this:

/cherrypick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2023
Closed
@openshift-cherrypick-robot
Copy link

@atiratree: new pull request created: #1385

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@atiratree @openshift-ci-robot @ardaguclu @soltysh @prb112 @openshift-cherrypick-robot @openshift-merge-robot