Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: Image commands should all support file targets #139

Merged

Conversation

smarterclayton
Copy link
Contributor

Enable “file://“ support for all other image commands except catalog, which will be a follow up PR. Allows tooling to work against local paths for extract / view.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2019
Prepare to allow other image commands to use references like this.
Write the temporary file to disk and then move it to the final
location, while calculating the appropriate blob hash.
…mmands

Add file:// and s3:// support to all image and release commands.
Allow `oc adm catalog build` to target files, like image append.
Simplifies a few cases where canonical references may be used,
someone may legitimately use it.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 982438f into openshift:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants