Add cli artifacts image #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
tnozicka
force-pushed
the
add-cli-artifacts-image
branch
from
8feb5c1
to
d8a9a99
Compare
openshift-ci-robot
added
size/XXL
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
tnozicka
commented
Aug 1, 2019
| GO_LD_EXTRAFLAGS :=-X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitMajor="1" \ | ||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitMinor="14" \ | ||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitVersion="v1.14.0+724e12f93f" \ | ||
| -X github.com/openshift/oc/vendor/k8s.io/kubernetes/pkg/version.gitCommit="$(SOURCE_GIT_COMMIT)" \ |
There was a problem hiding this comment.
moved it so the SOURCE_GIT_COMMIT is defined at this point
tnozicka
force-pushed
the
add-cli-artifacts-image
branch
from
d8a9a99
to
fcf4c9f
Compare
tnozicka
force-pushed
the
add-cli-artifacts-image
branch
from
fcf4c9f
to
55a3aad
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sanchezl
pushed a commit
to sanchezl/oc
that referenced
this pull request
Aug 5, 2019
adding deployment configs to default collection of namespace objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @deads2k @sallyom