Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event filter and complete event json to inspect the must-gather results #451

Merged

Conversation

retroflexer
Copy link
Contributor

@retroflexer retroflexer commented Jun 3, 2020

The event filter is based on free jqgrid available here: https://github.com/free-jqgrid/jqGrid/. jqGrid is a popular jQuery Plugin for displaying and editing data in tabular form.

This is built on the top of PR #448.

@retroflexer
Copy link
Contributor Author

/retest

@retroflexer
Copy link
Contributor Author

/test e2e-cmd

@retroflexer
Copy link
Contributor Author

If we must make it a single file, we should write all-events.json as a html file with the entire json assigned to a javascript variable. @deads2k

@deads2k
Copy link
Contributor

deads2k commented Jun 5, 2020

Can this be wired so it has the all-events.json pre-loaded when I click the html. Every little bit helps.

@deads2k
Copy link
Contributor

deads2k commented Jun 5, 2020

Also, can it inject newlines when it sees \n?

Status for clusteroperator/kube-apiserver changed: Degraded message changed from "NodeControllerDegraded: All master nodes are ready" to "StaticPodsDegraded: pod/kube-apiserver-ip-10-0-198-156.us-west-1.compute.internal container \"kube-apiserver\" is not ready: PodInitializing: \nStaticPodsDegraded: pod/kube-apiserver-ip-10-0-198-156.us-west-1.compute.internal container \"kube-apiserver-cert-regeneration-controller\" is not ready: PodInitializing: \nStaticPodsDegraded: pod/kube-apiserver-ip-10-0-198-156.us-west-1.compute.internal container \"kube-apiserver-cert-syncer\" is not ready: PodInitializing: \nStaticPodsDegraded: pod/kube-apiserver-ip-10-0-198-156.us-west-1.compute.internal container \"kube-apiserver-insecure-readyz\" is not ready: PodInitializing: \nNodeControllerDegraded: All master nodes are ready"

as a for instance

@retroflexer
Copy link
Contributor Author

retroflexer commented Jun 5, 2020

Also, can it inject newlines when it sees \n?

For html, '\n' should be replaced with <br/> (line-break). I will do that.

@retroflexer retroflexer force-pushed the add-event-viewer-html branch 4 times, most recently from eea681e to deb8c03 Compare June 7, 2020 03:34
@retroflexer
Copy link
Contributor Author

/retest

@retroflexer retroflexer force-pushed the add-event-viewer-html branch 3 times, most recently from 45457a4 to c34a83f Compare June 8, 2020 13:30
@deads2k
Copy link
Contributor

deads2k commented Jun 8, 2020

it worked!

I can't lgtm my own work though.

@retroflexer still need to get those newlines

@retroflexer retroflexer force-pushed the add-event-viewer-html branch 2 times, most recently from c516283 to 0fca3f1 Compare June 8, 2020 16:00
@retroflexer
Copy link
Contributor Author

/retest

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Let's get this in and continue improving from there on

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: retroflexer, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@soltysh
Copy link
Member

soltysh commented Jun 9, 2020

/hold
@retroflexer how this relates to openshift/cluster-debug-tools#5?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2020
@retroflexer
Copy link
Contributor Author

@retroflexer how this relates to openshift/cluster-debug-tools#5?

The code is similar. The event filter can be used with CI runs, must gather or general events.json file. I put together all those variations in the cluster-debug-tools. Here is the specific use with must-gather events.

The file https://github.com/openshift/cluster-debug-tools/blob/master/web/event-filter/event-filter-local-jsonstr.html is identical to the code used here in pkg/cli/admin/inspect/eventFilterPage.go.

@soltysh
Copy link
Member

soltysh commented Jun 9, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2020
@retroflexer
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a3098c5 into openshift:master Jun 9, 2020
@retroflexer retroflexer deleted the add-event-viewer-html branch June 10, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants