New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event filter and complete event json to inspect the must-gather results #451
Add event filter and complete event json to inspect the must-gather results #451
Conversation
/retest |
/test e2e-cmd |
If we must make it a single file, we should write all-events.json as a html file with the entire json assigned to a javascript variable. @deads2k |
Can this be wired so it has the |
Also, can it inject newlines when it sees
as a for instance |
For html, '\n' should be replaced with |
eea681e
to
deb8c03
Compare
/retest |
45457a4
to
c34a83f
Compare
it worked! I can't lgtm my own work though. @retroflexer still need to get those newlines |
c516283
to
0fca3f1
Compare
0fca3f1
to
9390b89
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Let's get this in and continue improving from there on
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: retroflexer, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
The code is similar. The event filter can be used with CI runs, must gather or general events.json file. I put together all those variations in the cluster-debug-tools. Here is the specific use with must-gather events. The file https://github.com/openshift/cluster-debug-tools/blob/master/web/event-filter/event-filter-local-jsonstr.html is identical to the code used here in pkg/cli/admin/inspect/eventFilterPage.go. |
/hold cancel |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
The event filter is based on free jqgrid available here: https://github.com/free-jqgrid/jqGrid/. jqGrid is a popular jQuery Plugin for displaying and editing data in tabular form.
This is built on the top of PR #448.