Bug 1868384: Login: Avoid overwriting same user from different cluster #537
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@alvaroaleman: This pull request references Bugzilla bug 1868384, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
that e2e test is just 99% percent red, so I don't think its the fault of this PR: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-oc-master-e2e-cmd |
|
/assign @soltysh |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@alvaroaleman: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
alvaroaleman
force-pushed
the
wtf-user
branch
from
27656f0
to
89c013f
Compare
|
/test e2e-aws |
|
/retest |
| @@ -47,6 +47,7 @@ func CreateConfig(namespace, userName string, clientCfg *restclient.Config) (*cl | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| userName = userName + "/" + clusterNick | |||
There was a problem hiding this comment.
You'd need to move this after getContextNicknameFromConfig otherwise you'll end up with context having clusterNick twice.
I also wonder if not reversing the order, even though this seems intuitive, contextNick has them reversed so it'll be more reasonable to keep that same approach here as well.
alvaroaleman
force-pushed
the
wtf-user
branch
2 times, most recently
from
b423f5d
to
91d0916
Compare
alvaroaleman
force-pushed
the
wtf-user
branch
from
91d0916
to
4553af4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
|
Failures unrelated to this PR |
|
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-agnostic-cmd In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alvaroaleman: All pull requests linked via external trackers have merged: Bugzilla bug 1868384 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.6 |
|
@soltysh: new pull request created: #619 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@soltysh: new pull request created: #620 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.