-
Notifications
You must be signed in to change notification settings - Fork 189
Fail validation if arbiter and flexibleScaling both are enabled #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail validation if arbiter and flexibleScaling both are enabled #1010
Conversation
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
4577369 to
0b400e4
Compare
|
@jarrpa @umangachapagain This fixes the bug https://bugzilla.redhat.com/show_bug.cgi?id=1913357. cc: @iamniting |
|
@raghavendra-talur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jarrpa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vbnrh This would be another create use case to add to the admission controller. |
|
@raghavendra-talur I think we should cheery-pick this to the 4.7 branch |
|
/cherry-pick release-4.7 |
|
@agarwal-mudit: #1010 failed to apply on top of branch "release-4.7": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@raghavendra-talur This has conflicts, can we manually create a backport PR for this? |
Created #1030 |
No description provided.