Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--binary with relative fails #2266

Closed
kadel opened this issue Oct 9, 2019 · 6 comments · Fixed by #2211
Closed

--binary with relative fails #2266

kadel opened this issue Oct 9, 2019 · 6 comments · Fixed by #2211
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented Oct 9, 2019

I'm seeing an issue that I didn't see in a previous version.

git clone https://github.com/openshift-evangelists/Wild-West-Backend
cd Wild-West-Backend
mvn clean package
odo login
odo project create ododemo
odo create java backend --binary target/wildwest-1.0.jar

gives this error:

✗ Rel: can't make target/wildwest-1.0.jar relative to /Users/jkleiner/Downloads/Wild-West-Backend

I did not get that error in odo v1.0.0-beta6 (0cdcc90)

Originally posted by @jankleinert in #2265 (comment)

@kadel
Copy link
Member Author

kadel commented Oct 9, 2019

/kind bug
/priority medium

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Oct 9, 2019
@girishramnani
Copy link
Contributor

I can take a look at this

@girishramnani girishramnani self-assigned this Oct 9, 2019
@kadel
Copy link
Member Author

kadel commented Oct 10, 2019

I can take a look at this

This is already solved in #2211

@kadel
Copy link
Member Author

kadel commented Oct 10, 2019

/unassign

@amitkrout
Copy link
Contributor

@prietyc123 Is it the same issue you are facing while validating the command in doc steps ?

@prietyc123
Copy link
Contributor

@amitkrout Yes I am facing the same issue while validating the docs.

$ odo create java test3 --binary target/*.jar
 ✗  Rel: can't make target/spring-petclinic-2.1.0.BUILD-SNAPSHOT.jar relative to /Users/pkumari/spring-petclinic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants