Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step to compress before publishing artifacts to appveyor #1029

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@syamgk
Copy link
Contributor

commented Nov 22, 2018

add step to compress before publishing artifacts to appveyor

What is the purpose of this change? What does it change?

to reduce the storage consumption on appveyor

Was the change discussed in an issue?

https://github.com/redhat-developer/odo/issues/1025

How to test changes?

check if artifacts are publishing on appveyor in a compressed form and validate the binaries

@codeclimate

This comment has been minimized.

Copy link

commented Nov 22, 2018

Code Climate has analyzed commit f47a5a9 and detected 0 issues on this pull request.

View more on Code Climate.

@AppVeyorBot

This comment has been minimized.

@syamgk syamgk changed the title [WIP] add step to compress before publishing artifacts to appveyor add step to compress before publishing artifacts to appveyor Nov 22, 2018
@@ -32,12 +32,19 @@ test_script:
build_script:
- make cross

after_build:

This comment has been minimized.

Copy link
@kadel

kadel Nov 22, 2018

Member

Wouldn't it be better to run this after tests (after_test)?
Currently, it builds binaries, than gzips it, and then run tests. But gzipping doesn't make sense if tests don't pass.

This comment has been minimized.

Copy link
@syamgk

syamgk Nov 22, 2018

Author Contributor

yep, ack!

@codecov

This comment has been minimized.

Copy link

commented Nov 22, 2018

Codecov Report

Merging #1029 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   46.24%   46.12%   -0.12%     
==========================================
  Files          21       21              
  Lines        3419     3419              
==========================================
- Hits         1581     1577       -4     
- Misses       1678     1682       +4     
  Partials      160      160
Impacted Files Coverage Δ
pkg/component/watch.go 69.59% <0%> (-2.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21872d...f47a5a9. Read the comment docs.

@syamgk syamgk force-pushed the syamgk:gzip-artifacts-appve branch from 75a2336 to 395240d Nov 22, 2018
add step to compress before publishing artifacts to appveyor
@syamgk syamgk force-pushed the syamgk:gzip-artifacts-appve branch from 395240d to f47a5a9 Nov 22, 2018
@AppVeyorBot

This comment has been minimized.

@kadel
kadel approved these changes Nov 22, 2018
Copy link
Contributor

left a comment

LGTM
(will merge when travis is 💚 )

@surajnarwade surajnarwade merged commit e058c76 into openshift:master Nov 22, 2018
3 checks passed
3 checks passed
GolangCI No issues found!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.