Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the mattermost link and added google groups link in templates #2004

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@girishramnani
Copy link
Collaborator

commented Aug 12, 2019

What is the purpose of this change? What does it change?

see $SUBJECT

Was the change discussed in an issue?

fixes #1931

How to test changes?

check the github templates

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

+1, Good stuff before GA
/approve

Copy link
Collaborator

left a comment

Nitpicking here but it should be "Google group" and not "google group".

@dharmit

This comment has been minimized.

Copy link
Collaborator

commented Aug 12, 2019

That doesn't look like a publicly accessible Google group to me. @girishramnani @kadel

The chat room is at: https://chat.openshift.io/developers/channels/odo
The group is at: https://groups.google.com/a/redhat.com/forum/#!forum/devtools-odo

This comment has been minimized.

Copy link
@mik-dass

mik-dass Aug 12, 2019

Collaborator

This google group is private to red hat employees

This comment has been minimized.

Copy link
@girishramnani

girishramnani Aug 12, 2019

Author Collaborator

I remember steve mentioning a group, I will find that out

This comment has been minimized.

Copy link
@kadel

kadel Aug 12, 2019

Member

This is a different group.

Public odo group is odo-users

@kadel

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

/hold

wrong google group.
The right one is https://groups.google.com/forum/#!forum/odo-users

Copy link
Collaborator

left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Aug 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

/hold cancel

@kadel

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit eab926a into openshift:master Aug 12, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Needs lgtm label.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/benchmark Job succeeded.
Details
ci/prow/e2e-scenarios Job succeeded.
Details
ci/prow/integration Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.