Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Suraj from OWNERS and replace him with Dharmit #2011

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@kadel
Copy link
Member

commented Aug 13, 2019

Adding @dharmit to @surajnarwade place

fixes #2002

Copy link
Collaborator

left a comment

$ git grep "surajnarwade"
OWNERS:- surajnarwade 
OWNERS:- surajnarwade 
pkg/auth/OWNERS:- surajnarwade 
pkg/auth/OWNERS:- surajnarwade 
pkg/catalog/OWNERS:- surajnarwade
pkg/catalog/OWNERS:- surajnarwade
pkg/occlient/OWNERS:- surajnarwade
pkg/occlient/OWNERS:- surajnarwade
pkg/odo/OWNERS:- surajnarwade
pkg/odo/OWNERS:- surajnarwade
pkg/secret/OWNERS:- surajnarwade
pkg/secret/OWNERS:- surajnarwade
pkg/service/OWNERS:- surajnarwade 
pkg/service/OWNERS:- surajnarwade
pkg/util/OWNERS:- surajnarwade 
pkg/util/OWNERS:- surajnarwade 
site/OWNERS:- surajnarwade 
site/OWNERS:- surajnarwade

Just for reviewer reference

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Aug 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdrage
cdrage approved these changes Aug 13, 2019
Copy link
Collaborator

left a comment

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 8ff9200 into openshift:master Aug 13, 2019
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/benchmark Job succeeded.
Details
ci/prow/e2e-scenarios Job succeeded.
Details
ci/prow/integration Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.