Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests so they run on openshift 4.2 #2059

Merged
merged 1 commit into from Sep 9, 2019
Merged

update tests so they run on openshift 4.2 #2059

merged 1 commit into from Sep 9, 2019

Conversation

kadel
Copy link
Member

@kadel kadel commented Aug 29, 2019 •
edited

a few changes to tests to make them run on 4.2

fixes #2049

issues were:

@kadel kadel force-pushed the update-test-for-4.2 branch 2 times, most recently from ea40944 to fbe5866 Compare August 29, 2019 14:33
@kadel kadel mentioned this pull request Aug 29, 2019
Closed
@kadel
Copy link
Member Author

kadel commented Aug 29, 2019

/retest

[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

amitkrout
amitkrout suggested changes Aug 30, 2019
View reviewed changes
tests/integration/cmd_storage_test.go Outdated
@@ -41,8 +41,8 @@ var _ = Describe("odo storage command", func() {

Context("when running storage command without required flag(s)", func() {
It("should fail", func() {
helper.CopyExample(filepath.Join("source", "dotnet"), context)
helper.CmdShouldPass("odo", "component", "create", "dotnet", "dotnet", "--app", "dotnetapp", "--project", project, "--context", context)
helper.CopyExample(filepath.Join("source", "openjdk"), context)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need import java IS oc.ImportJavaIs(project). Why dotnet component is removed ?

Copy link
Contributor

@mik-dass mik-dass Aug 30, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @amitkrout pointed out, why is the dotnet test replaced with java:8? Also why are we not checking for java imagestream here?

Copy link
Member Author

@kadel kadel Sep 2, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is never creating the component. So it doesn't really matter.
DotNet image has a lot of problems, and it is not our primary focus right now.

Purpose of this test is to test url, everything else is just adding time. I will change this to nodejs, so we don't have to import any extra builder images

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, understandable.

amitkrout
amitkrout reviewed Aug 30, 2019
View reviewed changes
tests/integration/java_test.go Outdated
@@ -73,10 +73,10 @@ var _ = Describe("odoJavaE2e", func() {
})

It("Should be able to deploy a git repo that contains a java uberjar application using openjdk", func() {
oc.ImportJavaIsToNspace(project)
oc.ImportJavaIs(project)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel ImportJavaIsToNspace is more talkative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2059 (review)

amitkrout
amitkrout reviewed Aug 30, 2019
View reviewed changes
tests/integration/source_test.go Outdated
@@ -121,6 +121,8 @@ var _ = Describe("odoSourceE2e", func() {
})

It("Should be able to deploy a dotnet source application", func() {
oc.ImportDotnet20Is(project)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now i can understand why you use ImportJavaIs instead of ImportJavaIsToNspace.

+1 for ImportDotnet20Is

amitkrout
amitkrout suggested changes Aug 30, 2019
View reviewed changes
tests/helper/helper_oc.go
val, ok := os.LookupEnv("CI")
if ok && val == "openshift" {
// checkForImageStream checks if there is a ImageStram with name and tag in openshift namespace
func (oc *OcRunner) checkForImageStream(name string, tag string) bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the namespace as an argument so that the function can also check the IS in a specified namespace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed, anywhere. The only place where we want to check is openshift namespace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, if later there will be a need then will expose that argument.

@kadel kadel force-pushed the update-test-for-4.2 branch 2 times, most recently from 2f6c931 to ae61757 Compare September 2, 2019 12:33
@kadel
Copy link
Member Author

kadel commented Sep 2, 2019

/retest

2019/09/02 13:14:01 error: unable to signal to artifacts container to terminate in pod e2e-scenarios, triggering deletion: could not run remote command: container artifacts is not valid for pod e2e-scenarios
2019/09/02 13:14:01 error: unable to retrieve artifacts from pod e2e-scenarios: could not read gzipped artifacts: container artifacts is not valid for pod e2e-scenarios
2019/09/02 13:14:06 error: could not wait for pod 'e2e-scenarios': it is no longer present on the cluster (usually a result of a race or resource pressure. re-running the job should help)
2019/09/02 13:14:07 Ran for 39m51s
2019/09/02 13:14:07 Submitted failure event to sentry (id=f56f0826d8914a4c8171d1714d70651c)
error: could not run steps: step e2e-scenarios failed: template pod "e2e-scenarios" failed: pod was deleted while ci-operator step was waiting for it

@kadel
Copy link
Member Author

kadel commented Sep 2, 2019

/retest

[odo]  ✗  Unable to connect to OpenShift cluster, is it down?

@kadel kadel mentioned this pull request Sep 2, 2019
Merged
@kadel
Copy link
Member Author

kadel commented Sep 2, 2019

/retest

2019/09/02 14:04:19 error: unable to signal to artifacts container to terminate in pod integration, triggering deletion: could not run remote command: container artifacts is not valid for pod integration
2019/09/02 14:04:19 error: unable to retrieve artifacts from pod integration: could not read gzipped artifacts: container artifacts is not valid for pod integration
2019/09/02 14:04:24 error: could not wait for pod 'integration': it is no longer present on the cluster (usually a result of a race or resource pressure. re-running the job should help)
2019/09/02 14:04:25 Ran for 1h30m20s
2019/09/02 14:04:25 Submitted failure event to sentry (id=1b053eecc2cd49488f9ab3838a593ba1)
error: could not run steps: step integration failed: template pod "integration" failed: pod was deleted while ci-operator step was waiting for it

@amitkrout
Copy link
Contributor

/test benchmark
/test integration

mik-dass
mik-dass approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 3, 2019
@mik-dass
Copy link
Contributor

mik-dass commented Sep 3, 2019 

[odo]  ✗  Failed To Update Config To Component Deployed
[odo]  ✗  Applying configuration [5m]

/retest

@kadel
Copy link
Member Author

kadel commented Sep 4, 2019 

2019/09/03 10:04:23 error: unable to signal to artifacts container to terminate in pod integration, triggering deletion: could not run remote command: container artifacts is not valid for pod integration
2019/09/03 10:04:23 error: unable to retrieve artifacts from pod integration: could not read gzipped artifacts: container artifacts is not valid for pod integration
2019/09/03 10:04:27 error: could not wait for pod 'integration': it is no longer present on the cluster (usually a result of a race or resource pressure. re-running the job should help)
E0903 10:04:27.803140      14 event.go:191] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".15c0e58ddddb3bec", GenerateName:"", Namespace:"ci-op-00nzk9zs", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-00nzk9zs", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-odo-master-integration for PR https://github.com/openshift/odo/pull/2059 in namespace ci-op-00nzk9zs from author kadel", Source:v1.EventSource{Component:"ci-op-00nzk9zs", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbf53ac8aefb24dec, ext:5493845526774, loc:(*time.Location)(0x26765e0)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbf53ac8aefb24dec, ext:5493845526774, loc:(*time.Location)(0x26765e0)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events ".15c0e58ddddb3bec" is forbidden: unable to create new content in namespace ci-op-00nzk9zs because it is being terminated' (will not retry!)
2019/09/03 10:04:28 Ran for 1h31m34s
2019/09/03 10:04:29 Submitted failure event to sentry (id=53f06f8b55764623a68a9a022dc0b3ad)

/retest

@amitkrout amitkrout mentioned this pull request Sep 4, 2019
Merged
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 4, 2019
@amitkrout
Copy link
Contributor

/test benchmark

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 5, 2019
@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 5, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d8deed8 into redhat-developer:master Sep 9, 2019
@dharmit dharmit mentioned this pull request Sep 26, 2019
Merged
@rm3l rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout requested changes

@mik-dass mik-dass mik-dass approved these changes

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open JDK binary source URL does not come up
7 participants
@kadel @amitkrout @openshift-ci-robot @mik-dass @openshift-bot @rm3l @openshift-merge-robot