Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes update information italic text #2086

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@cdrage
Copy link
Collaborator

commented Sep 4, 2019

Changes the update information to display at italic in order to not get
mixed in with the other output.

Also remove the quotes for odo preference set UpdateNotification false
so it's easier to copy-and-paste from the terminal.

To test:

  1. Modify pkg/odo/cli/version/version.go VERSION var to "v1.0.0-beta4"
    or any version previous
  2. Compile
  3. Run a standard create command odo create nodejs
Changes the update information to display at italic in order to not get
mixed in with the other output.

Also remove the quotes for `odo preference set UpdateNotification false`
so it's easier to copy-and-paste from the terminal.

To test:

 1. Modify pkg/odo/cli/version/version.go VERSION var to "v1.0.0-beta4"
 or any version previous
 2. Compile
 3. Run a standard create command `odo create nodejs`
@cdrage

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 4, 2019

Demo:

Screenshot from 2019-09-04 14-25-58

@kadel

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@cdrage have you tested this on Windows?

@dharmit
dharmit approved these changes Sep 5, 2019
Copy link
Collaborator

left a comment

/approve

/hold to answer Windows question from @kadel.

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2019

@cdrage waiting on windows result. Once that's sorted will lgtm

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Italic does not work on Windows which is intentional. With the library, it instead uses bold / a different colour in PowerShell / CMD.

See below:
Screenshot from 2019-09-06 15-17-52

ping @kadel / @dharmit / @amitkrout

@dharmit

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

/hold cancel

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Sep 9, 2019

/lgtm

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2019

/retest all

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 9, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

/test benchmark

@openshift-merge-robot openshift-merge-robot merged commit 73fecae into openshift:master Sep 10, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/benchmark Job succeeded.
Details
ci/prow/e2e-scenarios Job succeeded.
Details
ci/prow/integration Job succeeded.
Details
ci/prow/unit Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.