Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ginkgo verbose mode #2145

Merged

Conversation

@amitkrout
Copy link
Collaborator

commented Sep 19, 2019

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #2074

NOTE: Make a practice of adding a verbose flag to every odo command in test file

How to test changes?

See the test result in the terminal locally

@girishramnani

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2019

we should allow an env variable to enable this too @amitkrout

@amitkrout amitkrout force-pushed the amitkrout:disableGinkgoVerboseMode branch from eb3c34e to 14bb4ac Sep 20, 2019
@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 20, 2019

we should allow an env variable to enable this too @amitkrout

Done.

@@ -7,6 +7,7 @@ set -x

export CI="openshift"
export TIMEOUT="30m"
export GINKGO_VERBOSE_MODE="-v"

This comment has been minimized.

Copy link
@mik-dass

mik-dass Sep 20, 2019

Collaborator

I don't see the verbose output in the tests running on the openshift cluster like before

This comment has been minimized.

Copy link
@amitkrout

amitkrout Sep 23, 2019

Author Collaborator

Locally it is disabled. To enable it locally see the doc changes in this pr.

This comment has been minimized.

@@ -7,6 +7,7 @@ set -x

export CI="openshift"
export TIMEOUT="30m"
export GINKGO_VERBOSE_MODE="-v"

* SLOW_SPEC_THRESHOLD: Env variable SLOW_SPEC_THRESHOLD is used for ginkgo tests. After this time (in second), ginkgo marks test as slow. The default value is set to 120s.

* GINKGO_VERBOSE_MODE: Env variable GINKGO_VERBOSE_MODE is used to get control over enabling ginkgo verbose mode against each test target run. By default ginkgo verbosity is not enabled. To enable verbosity export or set env GINKGO_VERBOSE_MODE like "GINKGO_VERBOSE_MODE=-v".

This comment has been minimized.

Copy link
@amitkrout

amitkrout Sep 23, 2019

Author Collaborator
@amitkrout amitkrout force-pushed the amitkrout:disableGinkgoVerboseMode branch from 5b5ecf0 to 55e596d Sep 24, 2019
@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 24, 2019

/test v4.2-integration

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 24, 2019

/refresh

@amitkrout amitkrout force-pushed the amitkrout:disableGinkgoVerboseMode branch from a4674cc to fc92cfe Sep 25, 2019
@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

level=fatal msg="failed to initialize the cluster: Multiple errors are preventing progress:\n* Cluster operator authentication is still updating: missing version information for oauth-openshift\n* Cluster operator console has not yet reported success\n* Cluster operator node-tuning has not yet reported success\n* Cluster operator openshift-samples is still updating\n* Could not update deployment \"openshift-operator-lifecycle-manager/packageserver\" (265 of 349): timed out waiting for the condition"

/test v4.1-e2e-scenarios

@cdrage
cdrage approved these changes Sep 30, 2019
Copy link
Collaborator

left a comment

Changes look good to me.

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

left a comment

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit ef844cb into openshift:master Oct 1, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.