Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump odo version to 1.0.0-beta6 #2182

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@dharmit
Copy link
Collaborator

commented Sep 25, 2019

Enhancements

  • Support for odo debug. odo now lets users debug the application running in the pod on OpenShift (#2043)
  • Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066)
  • Add json output for odo service list. This helps the consumers of odo, i.e., Adapters (#2098)
  • Add RPM spec for odo. Very soon, an RPM for odo will be available and odo could be installed with yum/dnf install odo (#2107)
  • Replace dumb-init with go-init. To avoid having to maintain our own RPM for dumb-init (#2130)
  • Refactor catalog code (#2133)
  • Print environment variables when linking a component with another component/service (#2035)

Bug Fixes

  • Fix populating parameters of service when created in non-interactive mode. odo service create didn't pick-up the values provided for parameters with -p flag (#2040)
  • Fix odo list for component that's not pushed. odo list output was empty for the components that have not been pushed (#2046)
  • Removes overlapping messages for odo git components (#2091)

Testing

  • Fixing e2e vs. integration naming (#1878)
  • Run tests on OpenShift 4.2 (#2059)
  • Add "pretty" library for testing (#2122)
    This makes debugging less painful to the eyes.

Documentation

  • Add development doc on machine readable output (#2123)
@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 25, 2019

Need to merge #2177 first.

@kadel

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

✗ Failed To Update Config To Component Deployed
#1981
/retest

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

/approve
ping @girishramnani

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Sep 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

Should I not be adding Enhancements, Fixes, etc. so that they show up on release page? Give me some time and I'll update the description of the PR with those details.

/hold

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

/hold cancel

ping @girishramnani @kadel

@girishramnani

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

A bit more description per point?

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

A bit more description per point?

Are you asking me to write an essay in Changelog? 🙄

UPDATE: Can you PTAL at the updated description?

@cdrage

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

I think that writing it in vim may have messed up the spacing, but when you do the release, turn:

Add json output for odo catalog list services (#2066)
This helps the consumers of odo, i.e., Adapters

To:

Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066)

Similar to the previous format, have it so that it's 1 sentence and that the link to the PR is at the end.

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 26, 2019

I think that writing it in vim may have messed up the spacing, but when you do the release, turn:

Add json output for odo catalog list services (#2066)
This helps the consumers of odo, i.e., Adapters

To:

Add json output for odo catalog list services. This helps the consumers of odo, i.e., Adapters (#2066)

Similar to the previous format, have it so that it's 1 sentence and that the link to the PR is at the end.

No, it wasn't vim. I edited the description on GH. But yeah I felt like it was a bit out of place. I'll modify that.

@@ -398,6 +406,28 @@ By default, builder images will be used from the current namespace. You can expl

A full list of component types that can be deployed is available using: 'odo catalog list'

[[debug]]
debug

This comment has been minimized.

Copy link
@kadel

kadel Sep 26, 2019

Member

Why is debug section empty?

This comment has been minimized.

Copy link
@dharmit

dharmit Sep 26, 2019

Author Collaborator

TBH, I'm not sure if that's something I should have added or make generate-cli-reference should have.

This comment has been minimized.

Copy link
@kadel

kadel Sep 26, 2019

Member

OK, no examples in the command-line. It will have to be fixed there.

/lgtm

@kadel

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

/retest

error: error pulling image registry.svc.ci.openshift.org/ci/clonerefs@sha256:99ef47c07da4a436f069583cb2326e9e8c2b0f296400eee48e865872a17a33eb: Get https://registry.svc.ci.openshift.org/v2/ci/clonerefs/manifests/sha256:99ef47c07da4a436f069583cb2326e9e8c2b0f296400eee48e865872a17a33eb: net/http: TLS handshake timeout
@openshift-merge-robot openshift-merge-robot merged commit 0cdcc90 into openshift:master Sep 26, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.