Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump odo version to 1.0.0-beta6 in "build/VERSION" file #2218

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@dharmit
Copy link
Collaborator

commented Oct 1, 2019

What is the purpose of this change? What does it change?

$subject

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

/test v4.1-e2e-scenarios

 [odo]  ✓  Triggering build from git [80ms]
[odo]  •  Waiting for build to finish  ...
[odo]  ✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name wo-wait-javaee-git-test. Please use `odo config view` to view settings used to create component. Error: unable to wait for build wo-wait-javaee-git-test-app-1 to run: timed out waiting for the conditio
@kadel

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

/lgtm
/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

[odo]  ✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name wo-wait-javaee-git-test. Please use `odo config view` to view settings used to create component. Error: unable to wait for build wo-wait-javaee-git-test-app-1 to run: timed out waiting for the condition

@dharmit I have a doubt here.
We have already release beta6 version and now the build VERSION file is changed to beta6. So don't you think the bits we released is not the proper beta6 then ? may be some metadata which depends on this file is not updated in the release bits.

@dharmit

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 1, 2019

I don't think that would be the reason behind the time out error here. @kadel WDYT?

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Oct 1, 2019

I don't think that would be the reason behind the time out error here. @kadel WDYT?

@dharmit Yup i understand, That was just a failure (flake) message which i pasted above of my comment. Can you please address which i asked after that

@openshift-bot

This comment has been minimized.

Copy link

commented Oct 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

This comment has been minimized.

Copy link

commented Oct 2, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5faa5f6 into openshift:master Oct 2, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.