Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine output for `odo app list` should be `Kind: List` #2228

Merged

Conversation

@cdrage
Copy link
Collaborator

commented Oct 2, 2019

Machine readable output for ApplicationList Kind should actually just be
Kind.

Machine readable output for ApplicationList Kind should actually just be
`Kind`.
@cdrage cdrage force-pushed the cdrage:update-applicationlist branch from 6ef5784 to 3c23a74 Oct 2, 2019
@girishramnani

This comment has been minimized.

Copy link
Collaborator

commented Oct 4, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

Test has been updated
/lgtm

@openshift-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 554f569 into openshift:master Oct 7, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.