Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentTypeList should be List in machine output #2230

Merged

Conversation

@cdrage
Copy link
Collaborator

commented Oct 2, 2019

For odo catalog list components machine-readable output for Kind
should simply be List

For `odo catalog list components` machine-readable output for `Kind`
should simply be `List`
@cdrage

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 2, 2019

/retest

@dharmit

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

@cdrage don't we have tests that check for the json output of odo catalog list -o json? Should we not have it?

cc @amitkrout

UPDATE: We do have tests for ServiceTypeList #2229. I think we should add for ComponentTypeList as well. 😄

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

@cdrage don't we have tests that check for the json output of odo catalog list -o json? Should we not have it?

cc @amitkrout

UPDATE: We do have tests for ServiceTypeList #2229. I think we should add for ComponentTypeList as well. 😄

Test has been updated for this pr - https://github.com/openshift/odo/pull/2230/files#diff-f0f2e54d32d2c1ab57020c3a3dd9a3fbR197.

/approve
/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

commented Oct 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 78a1a88 into openshift:master Oct 7, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.