Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crc stop to Deploy Application Section of README #2234

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@danielhelfand
Copy link
Contributor

commented Oct 3, 2019

What is the purpose of this change? What does it change?

#2226 caught most of the issues around adding crc to the README, but crc stop needs to be mentioned in addition to minishift stop.

Was the change discussed in an issue?

N/A

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 3, 2019

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amitkrout

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2019

/ok-to-test

+
[source,bash]
----
$ odo delete <component>
$ minishift stop
# or
$ crc stop
Comment for lines 140  – +146

This comment has been minimized.

Copy link
@amitkrout

amitkrout Oct 3, 2019

Collaborator

Can it be more clean like

+
[source,bash]
----
$ odo delete <component>
$ minishift stop
----
+
or
+
[source,bash]
----
$ odo delete <component>
$ crc stop
----

Screen Shot 2019-10-03 at 1 09 28 PM

Copy link
Collaborator

left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 95c30a0 into openshift:master Oct 3, 2019
8 of 9 checks passed
8 of 9 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.