Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include service and link command tests #2263

Conversation

@amitkrout
Copy link
Collaborator

commented Oct 9, 2019

What is the purpose of this change? What does it change?

Including link and service command test which were somehow misplace

Was the change discussed in an issue?

fixes #2262

How to test changes?

make test-cmd-service
make test-cmd-link-unlink

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 9, 2019

ping @kadel

@cdrage
cdrage approved these changes Oct 9, 2019
Copy link
Collaborator

left a comment

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 9, 2019

Copied from travis

ginkgo -v -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo service command tests" tests/integration/servicecatalog/
Running Suite: Servicecatalog Suite
===================================
Random Seed: 1570622205 - Will randomize all specs
Will run 18 specs
Running in parallel across 2 nodes
SSSS
------------------------------
[...]
------------------------------
Ran 11 of 18 Specs in 294.196 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 7 Skipped
Ginkgo ran 1 suite in 5m11.751635448s
Test Suite Passed
/home/travis/.travis/functions: line 553: 21948 Terminated              travis_jigger "${!}" "${timeout}" "${cmd[@]}"
The command "travis_wait make test-cmd-service" exited with 0.


353.01s$ make test-cmd-link-unlink
ginkgo -v -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo link and unlink command tests" tests/integration/servicecatalog/
Running Suite: Servicecatalog Suite
===================================
Random Seed: 1570622518 - Will randomize all specs
Will run 18 specs
Running in parallel across 2 nodes
S
------------------------------
[...]
------------------------------
Ran 7 of 18 Specs in 349.704 seconds
SUCCESS! -- 7 Passed | 0 Failed | 0 Pending | 11 Skipped
@kadel

This comment has been minimized.

Copy link
Member

commented Oct 9, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

commented Oct 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2bf3f38 into openshift:master Oct 9, 2019
9 checks passed
9 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.