Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds golintCI to travis job #2332

Merged
merged 2 commits into from Nov 7, 2019

Conversation

@mik-dass
Copy link
Collaborator

mik-dass commented Oct 30, 2019

What kind of PR is this?

/kind cleanup

What does does this PR do / why we need it:

It adds golangci-lint as a travis job
It also adds the golangci-lint as make target.
It also fixes the current lint errors in our code base.

Which issue(s) this PR fixes:

Fixes #1927

How to test changes / Special notes to the reviewer:

run golangci-lint run and check that no errors occur

@openshift-ci-robot openshift-ci-robot requested review from amitkrout and cdrage Oct 30, 2019
@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch 3 times, most recently from a8c7085 to 3d6b6cf Oct 30, 2019
@mik-dass mik-dass changed the title [WIP] Adds golintCI to travis job Adds golintCI to travis job Oct 30, 2019
@mik-dass mik-dass requested a review from kadel Oct 30, 2019
@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch 2 times, most recently from 6911532 to 29c12a9 Oct 30, 2019
@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Oct 31, 2019

/retest

pkg/component/watch_test.go Outdated Show resolved Hide resolved
for {
select {
case startMsg := <-StartChan:
if startMsg {
for _, fileModification := range tt.fileModifications {
startMsg := <-StartChan
if startMsg {
for _, fileModification := range tt.fileModifications {
Comment on lines 236 to 232

This comment has been minimized.

Copy link
@mik-dass

mik-dass Oct 31, 2019

Author Collaborator

@kadel Please have a look at this too

This comment has been minimized.

Copy link
@kadel

kadel Nov 6, 2019

Member

I think that the for loop is needed, as it is being used to wait for the data from the StartChan

@cdrage
cdrage approved these changes Oct 31, 2019
Copy link
Collaborator

cdrage left a comment

This is incredible! Thank you.

I don't see any issues with the ExtChan <- true section. Looks fine to me logically.

Everything else looks good and tests pass.

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Oct 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdrage

This comment has been minimized.

Copy link
Collaborator

cdrage commented Nov 1, 2019

Git commit message is blank and the PR description is very limited. Please update them both!

/hold

Screenshot from 2019-11-01 11-19-07

@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch 2 times, most recently from a2988bc to ead9f97 Nov 4, 2019
@openshift openshift deleted a comment from openshift-ci-robot Nov 4, 2019
@openshift openshift deleted a comment from openshift-ci-robot Nov 4, 2019
@openshift openshift deleted a comment from openshift-ci-robot Nov 4, 2019
@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Nov 4, 2019

Git commit message is blank and the PR description is very limited. Please update them both!

@cdrage Fixed

@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Nov 4, 2019

E1104 09:01:02.793480   16615 occlient.go:2664] Command 'tar xf - -C /tmp/src --strip 1' in container failed.
[odo] E1104 09:01:02.793514   16615 occlient.go:2665] stdout: 
[odo] E1104 09:01:02.793520   16615 occlient.go:2666] stderr: tar: /tmp/src: Cannot open: No such file or directory
[odo] tar: Error is not recoverable: exiting now
[odo] 

/retest

@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Nov 4, 2019

Running oc with args [oc get pods --namespace drcyasvliu --selector=deploymentconfig=nodejs-push-atonce-nodejs-create-now-test -o jsonpath='{.items[0].metadata.name}']
[oc] 'nodejs-push-atonce-nodejs-create-now-test-1-6blpv'Running oc with args [oc exec nodejs-push-atonce-nodejs-create-now-test-1-6blpv --namespace drcyasvliu -c nodejs-push-atonce-nodejs-create-now-test -- ls -la /tmp/src/package.json]
[oc] ls: cannot access /tmp/src/package.json: No such file or directory

/retest

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Nov 4, 2019

/hold cancel

@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch from ead9f97 to 9c84056 Nov 4, 2019
@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Nov 5, 2019

Caching blobs under "/var/cache/blobs".
[odo] Warning: Pull failed, retrying in 5s ...
[odo] Warning: Pull failed, retrying in 5s ...
[odo] Warning: Pull failed, retrying in 5s ...
[odo] error: build error: After retrying 2 times, Pull image still failed due to error: while pulling "docker://image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb" as "image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb": Error initializing source docker://image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb: pinging docker registry returned: Get https://image-registry.openshift-image-registry.svc:5000/v2/: dial tcp 172.30.13.161:5000: connect: no route to host

/retest

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Nov 5, 2019

Caching blobs under "/var/cache/blobs".
[odo] Warning: Pull failed, retrying in 5s ...
[odo] Warning: Pull failed, retrying in 5s ...
[odo] Warning: Pull failed, retrying in 5s ...
[odo] error: build error: After retrying 2 times, Pull image still failed due to error: while pulling "docker://image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb" as "image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb": Error initializing source docker://image-registry.openshift-image-registry.svc:5000/openshift/php@sha256:d30db914ff173925adb9e3a65d61e863e19ea679d80fe91ab6ac3c99bc5c5ccb: pinging docker registry returned: Get https://image-registry.openshift-image-registry.svc:5000/v2/: dial tcp 172.30.13.161:5000: connect: no route to host

/retest

@mik-dass This is network glitch. I have seen similar error in my previous minishift project

@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch from 9c84056 to 7e5a281 Nov 5, 2019
@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Nov 5, 2019

 Timed out after 600.000s.
    Running odo with args [odo service create -w dh-postgresql-apb --project vbnoqraanu --plan dev -p postgresql_user=luke -p postgresql_password=secret -p postgresql_database=my_data -p postgresql_version=9.6]
    Expected process to exit.  It did not.

/retest

}
ExtChan <- true
return nil

This comment has been minimized.

Copy link
@kadel

kadel Nov 6, 2019

Member

The error should be returned here

Copy link
Collaborator

amitkrout left a comment

@mik-dass #2362 went in. So please do a rebase.

mik-dass added 2 commits Oct 30, 2019
/kind cleanup

What does does this PR do / why we need it:

It adds golangci-lint as a travis job
It also adds the golangci-lint as make target.
It also fixes the current lint errors in our code base.

Which issue(s) this PR fixes:

Fixes #1927

How to test changes / Special notes to the reviewer:

run `golangci-lint run` and check that no errors occur

Signed-off-by: mik-dass <mrinald7@gmail.com>
@mik-dass mik-dass force-pushed the mik-dass:golint_fix branch from 3928622 to 3b3b2ee Nov 7, 2019
@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Nov 7, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit c281978 into openshift:master Nov 7, 2019
12 checks passed
12 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
tide In merge pool.
Details
@mik-dass mik-dass deleted the mik-dass:golint_fix branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.