Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PR template #2344

Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Nov 1, 2019

What kind of PR is this?

/kind cleanup

What does does this PR do / why we need it:

Updates the PR template (spelling error + new label)

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage cdrage changed the title ADD TITLE HERE Update the PR template Nov 1, 2019
@cdrage cdrage force-pushed the cdrage:update-pr-template-2 branch from a124cdf to 9189573 Nov 1, 2019
@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Nov 3, 2019

/retest

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Nov 3, 2019

/approve
/lgtm

Copy link
Collaborator

mik-dass left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani, mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [girishramnani,mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Nov 4, 2019

/retest

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Nov 4, 2019

/test v4.3-integration

**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->

/kind cleanup

**What does does this PR do / why we need it**:

Updates the PR template (spelling error + new label)

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage force-pushed the cdrage:update-pr-template-2 branch from 9189573 to 3de1fd8 Nov 6, 2019
@openshift-ci-robot openshift-ci-robot added size/S and removed size/XS labels Nov 6, 2019
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Nov 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Nov 7, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Nov 7, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 18bbde5 into openshift:master Nov 7, 2019
12 checks passed
12 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.