Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the development guide + add changelog script #2368

Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Nov 6, 2019

What kind of PR is this?

/kind code-refactoring
/kind docs

What does does this PR do / why we need it:

  • Adds changelog script to quickly generate a changelog using
    github_changelog_generator

Which issue(s) this PR fixes:

Fixes N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

--project odo \
-t $GITHUB_TOKEN \
--since-tag v1.0.0 \
--future-release v1.0.1 \

This comment has been minimized.

Copy link
@girishramnani

girishramnani Nov 7, 2019

Collaborator

Let this be user provided?

--user openshift \
--project odo \
-t $GITHUB_TOKEN \
--since-tag v1.0.0 \

This comment has been minimized.

Copy link
@girishramnani

girishramnani Nov 7, 2019

Collaborator

This could be taken from github releases as well via the api?

**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->

/kind code-refactorting
/kind docs

**What does does this PR do / why we need it**:

- Adds changelog script to quickly generate a changelog using
github_changelog_generator

**Which issue(s) this PR fixes**:

Fixes N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage force-pushed the cdrage:add-release-changelog-script branch from 75a1df8 to 3b59945 Nov 7, 2019
@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Nov 7, 2019

I have updated the branch again and it's updated now.

Copy link
Collaborator

mik-dass left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

. Update the release description (changelog) on GitHub. To make things easier, a script was created to automatically generate a CHANGELOG and output to stdout.
+
----
$ ./scripts/generate-changelog.sh ${PREVIOUS_VERSION} ${NEW_VERSION}

This comment has been minimized.

Copy link
@amitkrout

amitkrout Nov 13, 2019

Collaborator

+1

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Nov 13, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 57c2335 into openshift:master Nov 13, 2019
12 checks passed
12 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.