Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Space from Project Create Success Message #2375

Merged

Conversation

@danielhelfand
Copy link
Contributor

danielhelfand commented Nov 7, 2019

What kind of PR is this?

/kind cleanup

What does does this PR do / why we need it:

Removes space from project creation success message. The space is unnecessary and is not how odo commonly formats output.

Which issue(s) this PR fixes:

N/a

How to test changes / Special notes to the reviewer:

Create a project and verify extra space is gone:

$ odo project create myproject

Project 'myproject' is ready for use
New project created and now using project: myproject
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 7, 2019

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dharmit
dharmit approved these changes Nov 8, 2019
Copy link
Collaborator

dharmit left a comment

/ok-to-test
/approve
/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Nov 8, 2019

/needs-ok-to-test

@dharmit

This comment has been minimized.

Copy link
Collaborator

dharmit commented Nov 8, 2019

Failed to create cluster.

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"
@danielhelfand

This comment has been minimized.

Copy link
Contributor Author

danielhelfand commented Nov 8, 2019

/test v4.3-benchmark

@openshift-merge-robot openshift-merge-robot merged commit e8be804 into openshift:master Nov 8, 2019
12 checks passed
12 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.