Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automated deployments through TravisCI #2383

Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Nov 8, 2019

What kind of PR is this?

/kind cleanup

What does does this PR do / why we need it:

We no longer deploy through TravisCI / push our binaries to the GitHub
page. This removes the deployment feature from TravisCI so it does not
mess up our release.

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

Copy link
Collaborator

mik-dass left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

dharmit left a comment

/lgtm

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Nov 12, 2019

/retest

@cdrage cdrage force-pushed the cdrage:remove-build-binary-ci branch from 17f7fe7 to c1e599b Nov 12, 2019
@dharmit

This comment has been minimized.

Copy link
Collaborator

dharmit commented Nov 13, 2019

Same flake in all failures #2244 :

[odo]  ✗  Waiting for component to start [4m]
[odo]  ✗  waited 4m0s but couldn't find running pod matching selector: 'deploymentconfig=nodejs-app'

/test v4.1-integration
/test v4.2-integration
/test v4.3-integration

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Nov 13, 2019

/retest

**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->

/kind cleanup

**What does does this PR do / why we need it**:

We no longer deploy through TravisCI / push our binaries to the GitHub
page. This removes the deployment feature from TravisCI so it does not
mess up our release.

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage force-pushed the cdrage:remove-build-binary-ci branch from c1e599b to 2fe31e2 Nov 13, 2019
@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Nov 13, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit 37f76b6 into openshift:master Nov 13, 2019
12 checks passed
12 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.