Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and package for all RHEL architectures #2384

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@yselkowitz
Copy link
Contributor

yselkowitz commented Nov 8, 2019

What kind of PR is this?
/kind enhancement

What does does this PR do / why we need it:
OpenShift is currently available for X86-64 and IBM Power LE, and IBM Z is coming. IBM customers will expect to be able to download and run odo on their systems (particularly on Z where admins generally prefer homogeneous environments). oc is also available on all RHEL architectures:

https://mirror.openshift.com/pub/openshift-v4/clients/oc/4.2/

The same should apply to odo, particularly as download links thereto are provided from the console.

How to test changes / Special notes to the reviewer:
A successful scratch build has been done internally.

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 8, 2019

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot requested review from amitkrout and dharmit Nov 8, 2019
@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator

mohammedzee1000 commented Nov 9, 2019

/ok-to-test

@@ -32,24 +30,31 @@ OpenShift Do (odo) is a fast, iterative, and straightforward CLI tool for develo

%prep
%setup -q -n %{source_dir}
%patch0 -p1

This comment has been minimized.

Copy link
@mohammedzee1000

mohammedzee1000 Nov 9, 2019

Collaborator

Where exactly is this patch coming from?

This comment has been minimized.

Copy link
@yselkowitz

yselkowitz Nov 10, 2019

Author Contributor

Sorry, that was left over from earlier testing, fixed.

@yselkowitz yselkowitz force-pushed the multi-arch:master branch from 1fdd30b to 412c900 Nov 10, 2019
Copy link
Collaborator

dharmit left a comment

/lgtm

@mohammedzee1000 @kadel can one of you approve this?

@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator

mohammedzee1000 commented Nov 11, 2019

Looking good
/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit de26405 into openshift:master Nov 11, 2019
11 of 12 checks passed
11 of 12 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/v4.1-benchmark Job succeeded.
Details
ci/prow/v4.1-e2e-scenarios Job succeeded.
Details
ci/prow/v4.1-integration Job succeeded.
Details
ci/prow/v4.1-unit Job succeeded.
Details
ci/prow/v4.2-benchmark Job succeeded.
Details
ci/prow/v4.2-e2e-scenarios Job succeeded.
Details
ci/prow/v4.2-integration Job succeeded.
Details
ci/prow/v4.3-benchmark Job succeeded.
Details
ci/prow/v4.3-e2e-scenarios Job succeeded.
Details
ci/prow/v4.3-integration Job succeeded.
Details
@kadel

This comment has been minimized.

Copy link
Member

kadel commented Nov 11, 2019

Not sure if the alternative platform makes sense. odo is a developer tool, meant to be run on a developer's laptop. I don't expect anyone to run odo on IBM Z system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.