Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wait flag test in link command test #2398

Merged

Conversation

@amitkrout
Copy link
Collaborator

amitkrout commented Nov 13, 2019

What kind of PR is this?

/kind enhancement
/kind test

What does does this PR do / why we need it:
Adding test for missing flag in link test file
Which issue(s) this PR fixes:

Fixes #?No

How to test changes / Special notes to the reviewer:
make test-cmd-link-unlink

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 13, 2019

@amitkrout: The label(s) kind/enhancement cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

What kind of PR is this?

/kind enhancement
/kind test

What does does this PR do / why we need it:
Adding test for missing flag in link test file
Which issue(s) this PR fixes:

Fixes #?No

How to test changes / Special notes to the reviewer:
make test-cmd-link-unlink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mik-dass

This comment has been minimized.

Copy link
Collaborator

mik-dass commented Nov 13, 2019

https://travis-ci.com/openshift/odo/jobs/255970796#L3670

The test seems to be failing. I guess our wait flag is not working properly.

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Nov 19, 2019

https://travis-ci.com/openshift/odo/jobs/255970796#L3670

The test seems to be failing. I guess our wait flag is not working properly.

The failure is from env variable check

// ensure that the proper envFrom entry was created
envFromOutput := oc.GetEnvFromEntry("frontend", appName, project)
Expect(envFromOutput).To(ContainSubstring("backend"))
@amitkrout amitkrout force-pushed the amitkrout:missingWaitFlagInLinkTest branch from e41a47c to 6eddfca Nov 26, 2019
@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

amitkrout commented Nov 26, 2019

https://travis-ci.com/openshift/odo/jobs/255970796#L3670
The test seems to be failing. I guess our wait flag is not working properly.

The failure is from env variable check

// ensure that the proper envFrom entry was created
envFromOutput := oc.GetEnvFromEntry("frontend", appName, project)
Expect(envFromOutput).To(ContainSubstring("backend"))

Issue opened - #2414

helper.CmdShouldPass("odo", "push", "--context", context2)

// link both component and wait till frontend dc rollout properly
helper.CmdShouldPass("odo", "link", "backend", "--port", "8080", "--wait", "--context", context2)

This comment has been minimized.

Copy link
@kadel

kadel Nov 26, 2019

Member

context2 is the context for the backend component. So this command is trying to link component to itself.

This should be helper.CmdShouldPass("odo", "link", "backend", "--port", "8080", "--wait", "--context", context1)

It would be much better if the context1 and context2 have some meaningful names like backendContext and frontendContext to prevent mistakes like this.

This comment has been minimized.

Copy link
@amitkrout

amitkrout Nov 26, 2019

Author Collaborator

yup, Nice catch.

Will update the context naming accordingly

@openshift-ci-robot openshift-ci-robot added size/M and removed size/S labels Nov 26, 2019
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 26, 2019

@amitkrout: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/v4.1-integration e41a47c link /test v4.1-integration
ci/prow/v4.2-integration e41a47c link /test v4.2-integration
ci/prow/v4.3-integration e41a47c link /test v4.3-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

amitkrout commented Nov 27, 2019

Platform issue
/test v4.3-integration-e2e-benchmark

Copy link
Collaborator

mik-dass left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Nov 27, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 962d052 into openshift:master Nov 27, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.