Adding wait flag test in link command test

[amitkrout]

What kind of PR is this?

/kind enhancement
/kind test

What does does this PR do / why we need it:
Adding test for missing flag in link test file
Which issue(s) this PR fixes:

Fixes #?No

How to test changes / Special notes to the reviewer:
make test-cmd-link-unlink

[openshift-ci-robot]

@amitkrout: The label(s) kind/enhancement cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

What kind of PR is this?

/kind enhancement
/kind test

What does does this PR do / why we need it:
Adding test for missing flag in link test file
Which issue(s) this PR fixes:

Fixes #?No

How to test changes / Special notes to the reviewer:
make test-cmd-link-unlink

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mik-dass]

https://travis-ci.com/openshift/odo/jobs/255970796#L3670

The test seems to be failing. I guess our wait flag is not working properly.

[kadel]

https://travis-ci.com/openshift/odo/jobs/255970796#L3670

The test seems to be failing. I guess our wait flag is not working properly.

The failure is from env variable check

// ensure that the proper envFrom entry was created
envFromOutput := oc.GetEnvFromEntry("frontend", appName, project)
Expect(envFromOutput).To(ContainSubstring("backend"))

[amitkrout]

https://travis-ci.com/openshift/odo/jobs/255970796#L3670
The test seems to be failing. I guess our wait flag is not working properly.

The failure is from env variable check

// ensure that the proper envFrom entry was created
envFromOutput := oc.GetEnvFromEntry("frontend", appName, project)
Expect(envFromOutput).To(ContainSubstring("backend"))

Issue opened - #2414

[kadel]

context2 is the context for the backend component. So this command is trying to link component to itself.

This should be helper.CmdShouldPass("odo", "link", "backend", "--port", "8080", "--wait", "--context", context1)

It would be much better if the context1 and context2 have some meaningful names like backendContext and frontendContext to prevent mistakes like this.

[amitkrout]

yup, Nice catch.

Will update the context naming accordingly

[openshift-ci-robot]

@amitkrout: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/v4.1-integration	e41a47c	link	/test v4.1-integration
ci/prow/v4.2-integration	e41a47c	link	/test v4.2-integration
ci/prow/v4.3-integration	e41a47c	link	/test v4.3-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[amitkrout]

Platform issue
/test v4.3-integration-e2e-benchmark

[mik-dass]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• tests/OWNERS [mik-dass]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prietyc123]

/lgtm