Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up OpenShift CI files #2407

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@amitkrout
Copy link
Collaborator

amitkrout commented Nov 21, 2019

What kind of PR is this?

/kind cleanup
/kind test

What does does this PR do / why we need it:
Cleaning up openshiftci presubmit files.
Which issue(s) this PR fixes:

Fixes - No, however cleanup is needed after #2401 went in

How to test changes / Special notes to the reviewer:
OpenShift CI should pass

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

amitkrout commented Nov 21, 2019

 [odo]  ✗  Failed to create component with name nodejs. Please use `odo config view` to view
 settings used to create component. Error: unable to wait for build nodejs-myapp-1 to run: timed
 out waiting for the condition 

/test v4.1-integration-e2e-benchmark

@cdrage

This comment has been minimized.

Copy link
Collaborator

cdrage commented Nov 21, 2019

LGTM.
/lgtm

@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

amitkrout commented Nov 25, 2019

#2088
/test v4.1-integration-e2e-benchmark

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Nov 25, 2019

/approve

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Nov 25, 2019

/assign @amitkrout
/approve

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Nov 25, 2019

/approve

1 similar comment
@amitkrout

This comment has been minimized.

Copy link
Collaborator Author

amitkrout commented Nov 25, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Nov 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e0d4029 into openshift:master Nov 25, 2019
6 of 7 checks passed
6 of 7 checks passed
Travis CI - Pull Request Build Created
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.