Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed DEBUG_MODE to DEV_MODE in odo-debug design doc #2420

Merged
merged 1 commit into from Dec 17, 2019

Conversation

@girishramnani
Copy link
Collaborator

girishramnani commented Dec 2, 2019

What kind of PR is this?

/kind code-refactoring
/kind enhancement

What does does this PR do / why we need it:
After openshift/odo-init-image#45 is merged. we will be using DEV_MODE to control debug mode so we need to change the docs to reflect that information
Which issue(s) this PR fixes:

Partly #2409

How to test changes / Special notes to the reviewer:
Doc change

Copy link
Collaborator

mik-dass left a comment

/approve

@mik-dass

This comment has been minimized.

Copy link
Collaborator

mik-dass commented Dec 2, 2019

/hold
till openshift/odo-init-image#45 is merged

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator Author

girishramnani commented Dec 2, 2019

/retest

@girishramnani

This comment has been minimized.

Copy link
Collaborator Author

girishramnani commented Dec 13, 2019

openshift/odo-init-image#45 has been merged.

@girishramnani

This comment has been minimized.

Copy link
Collaborator Author

girishramnani commented Dec 16, 2019

/hold cancel

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Dec 17, 2019

/lgtm

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9990222 into openshift:master Dec 17, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.