Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for "FIt" script #2435

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Dec 6, 2019

What kind of PR is this?

/kind enhancement

What does does this PR do / why we need it:

Adds a small script to check for instances of FIt( being in the code.
This helps with regards to not merging in tests with FIt in integration.

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What kind of PR is this?**
<!--
DELETE the kind(s) which are not applicable before opening the PR.
-->

/kind enhancement

**What does does this PR do / why we need it**:

Adds a small script to check for instances of `FIt(` being in the code.
This helps with regards to not merging in tests with FIt in integration.

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 6, 2019

@cdrage: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them

In response to this:

What kind of PR is this?

/kind enhancement

What does does this PR do / why we need it:

Adds a small script to check for instances of FIt( being in the code.
This helps with regards to not merging in tests with FIt in integration.

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Dec 9, 2019

+1
/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Dec 9, 2019

/retest

Copy link
Collaborator

mik-dass left a comment

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 29937f6 into openshift:master Dec 10, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.