Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup OWNERS file #2442

Merged
merged 1 commit into from Dec 11, 2019
Merged

Conversation

@kadel
Copy link
Member

kadel commented Dec 9, 2019

  • Removed OWNERS file from pkg/* we are not that big to need to create separate areas like this (for now).
  • Relying mostly on top-level OWNERS file will make sure that review requests are distributed more equally.
  • Kept OWNERS for tests and scripts, as those contain highly specific things.

/cc @cdrage @girishramnani

there is also related change in prow config openshift/release#6198

@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator

mohammedzee1000 commented Dec 9, 2019

Awesome stuff, I was wondering when we would truly adopt this :)

@cdrage
cdrage approved these changes Dec 9, 2019
Copy link
Collaborator

cdrage left a comment

This all looks good to me!

Big old /approve from me :)

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Dec 10, 2019

Awesome stuff, I was wondering when we would truly adopt this :)

We can start right now. There are still some issues left to solve around github permissions and labels, but that shouldn't prevent us from adopting this for reviews

Copy link
Collaborator

mik-dass left a comment

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 1d8f8e4 into openshift:master Dec 11, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.