Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run e2e test in verbose #2450

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@kadel
Copy link
Member

kadel commented Dec 11, 2019

What kind of PR is this?
/kind test

What does does this PR do / why we need it:
We have a lot of tests and running everithing in verbose mode create
output with few thousends of lines and it makes it really hard to find
failures.
Ginkgo is smart enought to dump all availble output when for failing
test even if verbose mode is not enabled.

Which issue(s) this PR fixes:

Fixes #2350

How to test changes / Special notes to the reviewer:

We have a lot of tests and running everithing in verbose mode create
output with few thousends of lines and it makes it really hard to find
failures.
Ginkgo is smart enought to dump all availble output when for failing
test even if verbose mode is not enabled.
@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Dec 12, 2019

/retest

some weird CI error

[odo]  ✗  invalid configuration: [context was not found for specified context: rzdqyanktr/api-ci-op-zivw5d4i-00a90-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]
@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Dec 12, 2019

Copy link
Collaborator

mik-dass left a comment

/approve

@cdrage

This comment has been minimized.

Copy link
Collaborator

cdrage commented Dec 12, 2019

/lgtm

Although tests are failing >.>

@cdrage

This comment has been minimized.

Copy link
Collaborator

cdrage commented Dec 13, 2019

/test v4.1-integration-e2e-benchmark

Copy link
Collaborator

amitkrout left a comment

/lgtm

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Dec 15, 2019

/lgtm

/approve

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Dec 15, 2019

/refresh

1 similar comment
@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Dec 16, 2019

/refresh

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Dec 16, 2019

/approve

@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Dec 16, 2019

small fix -> self approve
/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Dec 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, kadel, mik-dass

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Dec 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 605ea6f into openshift:master Dec 16, 2019
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.