Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump release version 1.0.2 -> 1.0.3 #2504

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@mohammedzee1000
Copy link
Collaborator

mohammedzee1000 commented Jan 10, 2020

Preparing to release v1.0.3
What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Copy link
Collaborator

dharmit left a comment

Don't we need to change the version info in build/VERSION file?

And what about changing image reference in pkg/occlient/occlient.go in the variable defaultBootstrapperImage? Do we do that after updating the init image?

@mohammedzee1000

This comment has been minimized.

Copy link
Collaborator Author

mohammedzee1000 commented Jan 10, 2020

Don't we need to change the version info in build/VERSION file?

we do it after the release.

And what about changing image reference in pkg/occlient/occlient.go in the variable defaultBootstrapperImage? Do we do that after updating the init image?

Already updated

@dharmit

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Jan 10, 2020

Don't we need to change the version info in build/VERSION file?

That should be done only after release. This file is used by update notifier and we don't want for users to be notified about the new version before it is available to download.

And what about changing image reference in pkg/occlient/occlient.go in the variable defaultBootstrapperImage? Do we do that after updating the init image?

that was already updated. image has its own versioning and it doesn't have to be updated with each release

/approve

@dharmit

This comment has been minimized.

Copy link
Collaborator

dharmit commented Jan 10, 2020

Thanks for the answers @mohammedzee1000 @kadel

/lgtm

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Jan 10, 2020

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 181c82a into openshift:master Jan 10, 2020
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.