Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve typo in function comments #2508

Merged

Conversation

@girishramnani
Copy link
Collaborator

girishramnani commented Jan 13, 2020

What type of PR is this?

/kind documentation

What does does this PR do / why we need it:
see $SUBJECT
Which issue(s) this PR fixes:
No issue

How to test changes / Special notes to the reviewer:

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Jan 13, 2020

/retest

Copy link
Collaborator

amitkrout left a comment

/lgtm

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Jan 14, 2020

/approve

@prietyc123

This comment has been minimized.

Copy link
Collaborator

prietyc123 commented Jan 14, 2020

Looks good to me 👍

Copy link
Collaborator

prietyc123 left a comment

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Jan 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout, prietyc123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a39da91 into openshift:master Jan 14, 2020
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable.
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.