Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new reviewers to top level OWNERS #2556

Merged
merged 2 commits into from Feb 10, 2020
Merged

Conversation

@kadel
Copy link
Member

kadel commented Jan 31, 2020

Adding @johnmcollier, @maysunfaisal, @rajivnathan as reviewers.

Are you guys ok with becoming reviewers?
What it means is that you will be able to /lgtm PRs.

General info on how reviewers and approvers work can be found at https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#code-review-using-owners-files

add  johnmcollier, maysunfaisal, rajivnathan as reviewers
@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Jan 31, 2020

The following users are mentioned in OWNERS file(s) but are not members of the openshift org.

hmm :-(

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Feb 4, 2020

@kadel can we add them as members to the org?

@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Feb 4, 2020

/verify-owners

add elsony to reviewers
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2556 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2556      +/-   ##
==========================================
+ Coverage   44.45%   44.94%   +0.49%     
==========================================
  Files          53       73      +20     
  Lines        6314     8047    +1733     
==========================================
+ Hits         2807     3617     +810     
- Misses       3241     4107     +866     
- Partials      266      323      +57
Impacted Files Coverage Δ
pkg/devfile/parse.go 0% <0%> (ø)
pkg/devfile/versions/versions.go 100% <0%> (ø)
pkg/devfile/versions/helper.go 100% <0%> (ø)
pkg/devfile/writer.go 60% <0%> (ø)
pkg/devfile/parser/apiVersion.go 76.47% <0%> (ø)
pkg/devfile/parser/content.go 82.6% <0%> (ø)
pkg/testingutil/services.go 0% <0%> (ø)
pkg/devfile/parser/context.go 0% <0%> (ø)
pkg/devfile/parser/schema.go 61.9% <0%> (ø)
pkg/testingutil/fileutils.go 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1985f38...566c908. Read the comment docs.

@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Feb 7, 2020

/verify-owners

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Feb 7, 2020

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Feb 10, 2020

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 9cad478 into master Feb 10, 2020
6 of 7 checks passed
6 of 7 checks passed
tide Not mergeable. Retesting: ci/prow/v4.3-integration-e2e-benchmark
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.