Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog script #2587

Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Feb 10, 2020

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

Updates the changelog script to not include summary / epics / etc as
it was not properly generating

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

run ./scripts/changelog-script.sh

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What type of PR is this?**
> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line:

> /kind bug

**What does does this PR do / why we need it**:

Updates the changelog script to *not* include summary / epics / etc as
it was not properly generating

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

run ./scripts/changelog-script.sh

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@kadel

This comment has been minimized.

Copy link
Member

kadel commented Feb 11, 2020

/retest
/lgmt
/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Feb 11, 2020

/lgtm

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2587   +/-   ##
=======================================
  Coverage   42.65%   42.65%           
=======================================
  Files          73       73           
  Lines        7062     7062           
=======================================
  Hits         3012     3012           
  Misses       3763     3763           
  Partials      287      287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cad478...bdcfdfb. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 70137e4 into openshift:master Feb 11, 2020
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Retesting: ci/prow/v4.3-integration-e2e-benchmark
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
@cdrage cdrage added the kind/bug label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.