Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports ODO_LOG_LEVEL env variable in integration tests #2595

Merged
merged 2 commits into from Feb 19, 2020

Conversation

@mik-dass
Copy link
Collaborator

mik-dass commented Feb 12, 2020

What type of PR is this?

/kind code-refactoring

What does does this PR do / why we need it:

Expose ODO_LOG_LEVEL env to the integration tests for getting verbose logs for failing tests

How to test changes / Special notes to the reviewer:

Check that a failing test has verbose logs.

@mik-dass mik-dass changed the title Exports ODO_LOG_LEVEL env variable in integration tests [WIP] Exports ODO_LOG_LEVEL env variable in integration tests Feb 12, 2020
@mik-dass mik-dass force-pushed the mik-dass:odo_log_v branch from 83febc5 to 24c6bfe Feb 12, 2020
@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Feb 12, 2020

can we not keep this variable in the Makefile?

Copy link
Collaborator

amitkrout left a comment

@mik-dass You just need to add ODO_LOG_LEVEL ?= 4 in the Makefile instead of these changes.

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Feb 12, 2020

@mik-dass You just need to add ODO_LOG_LEVEL ?= 4 in the Makefile instead of these changes.

@mik-dass May be not. You need to find a better way to export the env variable in Makefile

@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Feb 13, 2020

@mik-dass You just need to add ODO_LOG_LEVEL ?= 4 in the Makefile instead of these changes.

Doesn't work.

@mik-dass May be not. You need to find a better way to export the env variable in Makefile

We are already defining env variables for Travis and are exposing env variable in the openshift CI too.
Exporting in makefile might complicate things when the user wants to apply a different value to the variable.

Also this approach works https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2595/pull-ci-openshift-odo-master-v4.3-integration-e2e-benchmark/623

But this seems to break json output, looking into it.

@mik-dass mik-dass changed the title [WIP] Exports ODO_LOG_LEVEL env variable in integration tests Exports ODO_LOG_LEVEL env variable in integration tests Feb 13, 2020
@mik-dass mik-dass force-pushed the mik-dass:odo_log_v branch from 24c6bfe to 404ddab Feb 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #2595 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
- Coverage    42.7%   42.59%   -0.12%     
==========================================
  Files          76       76              
  Lines        7203     7203              
==========================================
- Hits         3076     3068       -8     
- Misses       3830     3833       +3     
- Partials      297      302       +5
Impacted Files Coverage Δ
pkg/component/watch.go 66% <0%> (-5.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2a46a...c018c19. Read the comment docs.

@mik-dass mik-dass force-pushed the mik-dass:odo_log_v branch from 404ddab to 53d9881 Feb 18, 2020
@openshift-ci-robot openshift-ci-robot added size/S and removed size/XS labels Feb 18, 2020
@mik-dass

This comment has been minimized.

Copy link
Collaborator Author

mik-dass commented Feb 18, 2020

✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to update DeploymentConfig for nodejs component: unable to update the current DeploymentConfig nodejs-app: unable to update DeploymentConfig nodejs-app: Operation cannot be fulfilled on deploymentconfigs.apps.openshift.io "nodejs-app": the object has been modified; please apply your changes to the latest version and try again

/retest

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Feb 18, 2020

/lgtm

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Feb 18, 2020

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Feb 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Feb 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 265c965 into openshift:master Feb 19, 2020
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Retesting: ci/prow/v4.1-integration-e2e-benchmark
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
@mik-dass mik-dass deleted the mik-dass:odo_log_v branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.