Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information to pull request template #2714

Merged

Conversation

@cdrage
Copy link
Collaborator

cdrage commented Mar 12, 2020

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind documentation

What does does this PR do / why we need it:

Hopefully this fixes the confusion for uncommenting :)

Updates the description on "how" to uncomment so people don't get
confused

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

> /kind documentation

**What does does this PR do / why we need it**:

Hopefully this fixes the confusion for uncommenting :)

Updates the description on "how" to uncomment so people don't get
confused

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2714 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
- Coverage   43.92%   43.77%   -0.15%     
==========================================
  Files          86       86              
  Lines        7757     7757              
==========================================
- Hits         3407     3396      -11     
- Misses       4015     4023       +8     
- Partials      335      338       +3
Impacted Files Coverage Δ
pkg/component/watch.go 65.33% <0%> (-7.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4852786...95cd798. Read the comment docs.

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Mar 16, 2020

/approve
/lgtm

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cdrage

This comment has been minimized.

Copy link
Collaborator Author

cdrage commented Mar 16, 2020

/retest

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Copy link
Collaborator

mik-dass left a comment

/lgtm

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 2faf284 into openshift:master Mar 17, 2020
6 checks passed
6 checks passed
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.