Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a secret directory in docker file for private registry #2718

Merged

Conversation

@prietyc123
Copy link
Collaborator

prietyc123 commented Mar 13, 2020

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

It will create a secret directory inside container, So that we can use the tokens for private registry login

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:
It should pass.

@prietyc123

This comment has been minimized.

Copy link
Collaborator Author

prietyc123 commented Mar 13, 2020

/retest

@amitkrout

This comment has been minimized.

Copy link
Collaborator

amitkrout commented Mar 13, 2020

/lgtm

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Mar 13, 2020

/approve

@kadel

This comment has been minimized.

Copy link
Member

kadel commented Mar 13, 2020

/retest

1 similar comment
@prietyc123

This comment has been minimized.

Copy link
Collaborator Author

prietyc123 commented Mar 13, 2020

/retest

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2718 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2718      +/-   ##
==========================================
+ Coverage   43.42%   43.49%   +0.06%     
==========================================
  Files          86       86              
  Lines        7907     7907              
==========================================
+ Hits         3434     3439       +5     
+ Misses       4134     4131       -3     
+ Partials      339      337       -2
Impacted Files Coverage Δ
pkg/component/watch.go 72.66% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf059c...fdfcc1d. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 8d6422d into openshift:master Mar 13, 2020
5 of 6 checks passed
5 of 6 checks passed
tide Not mergeable. Retesting: ci/prow/v4.2-integration-e2e-benchmark
Details
Travis CI - Pull Request Build Passed
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.