Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for rollout #2731

Merged
merged 5 commits into from Mar 25, 2020
Merged

Wait for rollout #2731

merged 5 commits into from Mar 25, 2020

Conversation

@kadel
Copy link
Member

kadel commented Mar 18, 2020

What type of PR is this?

/kind bug
/area devfile

What does does this PR do / why we need it:
fixes problem when odo push wouldn't wait for new Pod after there was a change in Deployment

Which issue(s) this PR fixes:

Fixes #2661

How to test changes / Special notes to the reviewer:
use devfile component
odo push
update devfile
odo push

second push used to fail


// update devfile and push again
helper.ReplaceString("devfile.yaml", "name: FOO", "name: BAR")
helper.CmdShouldPass("odo", "push", "--devfile", "devfile.yaml", "--namespace", namespace)

This comment has been minimized.

Copy link
@kadel

kadel Mar 18, 2020

Author Member

This is a new important addition. It actually tests fix in this PR.

This comment has been minimized.

Copy link
@johnmcollier

johnmcollier Mar 18, 2020

Collaborator

Good catch, I should have added this when I wrote the tests.

@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Mar 18, 2020

/retest

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2731 into master will decrease coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2731      +/-   ##
==========================================
- Coverage   43.83%   43.59%   -0.25%     
==========================================
  Files          87       87              
  Lines        8043     8092      +49     
==========================================
+ Hits         3526     3528       +2     
- Misses       4171     4219      +48     
+ Partials      346      345       -1
Impacted Files Coverage Δ
...g/devfile/adapters/kubernetes/component/adapter.go 33.67% <0%> (-0.53%) ⬇️
pkg/kclient/deployments.go 34.66% <0%> (-54.99%) ⬇️
pkg/component/watch.go 74% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cdfe5...532cde2. Read the comment docs.

@kadel kadel force-pushed the kadel:wait-for-rollout branch from b853bff to 687a6be Mar 18, 2020
Copy link
Collaborator

rajivnathan left a comment

Thank you so much for helping with this fix! Just noticed a couple typos.

lgtm 👍

pkg/kclient/deployments.go Outdated Show resolved Hide resolved
pkg/devfile/adapters/kubernetes/component/adapter.go Outdated Show resolved Hide resolved
Copy link
Collaborator

rajivnathan left a comment

lgtm

@kadel kadel force-pushed the kadel:wait-for-rollout branch from e508d85 to 382d734 Mar 20, 2020
@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Mar 20, 2020

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link

openshift-ci-robot commented Mar 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@girishramnani

This comment has been minimized.

Copy link
Collaborator

girishramnani commented Mar 20, 2020

I can see 5 legitimate failures in the CI related to devfile @kadel .

• Failure [7.157 seconds]
odo devfile push command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:15
  when devfile push command is executed
  /go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:63
    should not build when no changes are detected in the directory and build when a file change is detected [It]
skipped 80 lines unfold_more
[odo]  ✓  Deleted project : mwcfllxvyl
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration
Deleting dir: /tmp/551487786
• Failure [7.227 seconds]
odo devfile push command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:15
  when devfile push command is executed
  /go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:63
    should build when no changes are detected in the directory and force flag is enabled [It]
skipped 50 lines unfold_more
[odo]  ✓  Deleted project : ctdcckqsqe
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration
Deleting dir: /tmp/958871729
• Failure [6.993 seconds]
odo devfile push command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:15
  Verify devfile push works
  /go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:45
    Check that odo push works with a devfile [It]
skipped 66 lines unfold_more
[odo]  ✓  Deleted project : eahsapgsib
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration
Deleting dir: /tmp/631770455
• Failure [7.340 seconds]
odo devfile push command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:15
  when devfile push command is executed
  /go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:63
    should be able to create a file, push, delete, then push again propagating the deletions [It]
skipped 70 lines unfold_more
[odo]  ✓  Deleted project : aylyrhgjru
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration
Deleting dir: /tmp/325446482
• Failure [7.431 seconds]
odo devfile push command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:15
  when devfile push command is executed
  /go/src/github.com/openshift/odo/tests/integration/cmd_devfile_push_test.go:63
    should delete the files from the container if its removed locally [It]
skipped 90 lines unfold_more
[Fail] odo devfile push command tests when devfile push command is executed [It] should delete the files from the container if its removed locally 
/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
}

// WaitForDeploymentRollout waits for deployment to finish rollout. Returns the state of the deployment after rollout.
func (c *Client) WaitForDeploymentRollout(deploymentName string) (*appsv1.Deployment, error) {

This comment has been minimized.

Copy link
@girishramnani

girishramnani Mar 20, 2020

Collaborator

can we get a unit test for this function?

This comment has been minimized.

Copy link
@amitkrout

amitkrout Mar 21, 2020

Collaborator

Same question

pkg/kclient/deployments.go Outdated Show resolved Hide resolved
pkg/kclient/deployments.go Show resolved Hide resolved
@kadel

This comment has been minimized.

Copy link
Member Author

kadel commented Mar 20, 2020

I can see 5 legitimate failures in the CI related to devfile @kadel .

ouch, messed something up after rebasing with latest master :-/

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

27 similar comments
@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

This comment has been minimized.

Copy link

openshift-bot commented Mar 25, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 38a5549 into openshift:master Mar 25, 2020
5 of 6 checks passed
5 of 6 checks passed
Travis CI - Pull Request Build Errored
Details
ci/prow/unit Job succeeded.
Details
ci/prow/v4.1-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.2-integration-e2e-benchmark Job succeeded.
Details
ci/prow/v4.3-integration-e2e-benchmark Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.