/openshift-ansible

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd_image hardcoded to registry.access.redhat.com #1915

Closed
maci0 opened this Issue May 18, 2016 · 5 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@maci0 @detiber @sdodson @tbielawa @codrinbucur
@maci0
Contributor

maci0 commented May 18, 2016

in

https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_facts/library/openshift_facts.py

etcd_image = 'registry.access.redhat.com/rhel7/etcd'

many enterprise customers have a local copy of these images, the fact should be
etcd_image = 'rhel7/etcd'
instead

@detiber detiber added kind/rfe priority/P2 labels May 18, 2016

@detiber

This comment has been minimized.

Show comment
Hide comment
@detiber

detiber May 18, 2016

Contributor

@sdodson any issues you see with this?
Contributor

detiber commented May 18, 2016

@sdodson any issues you see with this?
@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson May 18, 2016

Member

No, I think it's fine.
Member

sdodson commented May 18, 2016

No, I think it's fine.

maci0 added a commit to maci0/openshift-ansible that referenced this issue May 19, 2016

@maci0
remove hard reference to registry.access.redhat.com for etcd_image 
This change removes the hardcoded path to the etcd_image.
It may come from a local registry and not  registry.access.redhat.com
See openshift#1915
141c407

@maci0 maci0 referenced this issue May 19, 2016

Closed

remove hard reference to registry.access.redhat.com for etcd_image #1920

@tbielawa

This comment has been minimized.

Show comment
Hide comment
@tbielawa

tbielawa Nov 15, 2016

Member

This issue has been inactive for quite some time. Please update and reopen this issue if this is still a priority you would like to see action on.
Member

tbielawa commented Nov 15, 2016

This issue has been inactive for quite some time. Please update and reopen this issue if this is still a priority you would like to see action on.

@tbielawa tbielawa closed this Nov 15, 2016

@maci0

This comment has been minimized.

Show comment
Hide comment
@maci0

maci0 Jul 5, 2017

Contributor

This issue is still present.
Contributor

maci0 commented Jul 5, 2017

This issue is still present.
@codrinbucur

This comment has been minimized.

Show comment
Hide comment
@codrinbucur

codrinbucur Aug 30, 2017

I am running into this as well. Any reason to keep it hardcoded?

codrinbucur commented Aug 30, 2017

I am running into this as well. Any reason to keep it hardcoded?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment